From owner-svn-src-all@FreeBSD.ORG Fri Jul 26 21:26:14 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 5F457689 for ; Fri, 26 Jul 2013 21:26:14 +0000 (UTC) (envelope-from andrey@zonov.org) Received: from mail-pb0-f46.google.com (mail-pb0-f46.google.com [209.85.160.46]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 31EDD2133 for ; Fri, 26 Jul 2013 21:26:13 +0000 (UTC) Received: by mail-pb0-f46.google.com with SMTP id rq8so2487216pbb.33 for ; Fri, 26 Jul 2013 14:26:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:x-enigmail-version:content-type :x-gm-message-state; bh=QJESk5STmuhHQpAsYSlMAvYq6cF5xMxkXPQlb+2peUs=; b=pYt3xlpPk8cr/FCVNElhKt+wrXq3kqupjizJK7k5HQHJua6OOd3+W/ZTGmdv5Bbuyb 0QZd5aNL7C7wXP+PvUT8/DTJyWnb8Io8crWYgQQYyU6C0iIeoD51ZFlyU6tX/r+dxEaA 4PrOlMDNTTfLdADCl7ELVWy1cDuriYVcV1azaGiJReGCb91DvvkBDvpB3QIgBTQl1y7+ BirpD3LaMgJeeYqAa0hojRgypjxm/od7FgiM3/tihydf8yCD44Z1WfczsFzn+WrQrIue pLgiYzpVsp0lJryWJyckHlkG0AQv4y/3zrQ+j1kvcHanJEw1jnlcW2Yzq/UFtCOSA5lQ NRhA== X-Received: by 10.68.237.3 with SMTP id uy3mr17008636pbc.155.1374873973409; Fri, 26 Jul 2013 14:26:13 -0700 (PDT) Received: from zont-osx.swifttest.com (h-74-3-97-61.snva.ca.megapath.net. [74.3.97.61]) by mx.google.com with ESMTPSA id xl3sm62029203pbb.17.2013.07.26.14.26.11 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 26 Jul 2013 14:26:12 -0700 (PDT) Sender: Andrey Zonov Message-ID: <51F2E970.3070303@FreeBSD.org> Date: Fri, 26 Jul 2013 14:26:08 -0700 From: Andrey Zonov User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:17.0) Gecko/20130620 Thunderbird/17.0.7 MIME-Version: 1.0 To: Jilles Tjoelker Subject: Re: svn commit: r253662 - in head: lib/libc/gen sys/vm tools/tools/sysdoc References: <201307260200.r6Q207cB015223@svn.freebsd.org> <20130726150949.GC14175@stack.nl> In-Reply-To: <20130726150949.GC14175@stack.nl> X-Enigmail-Version: 1.5.1 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="----enig2WRQWRTFUJEHNMFAEIMTQ" X-Gm-Message-State: ALoCoQl5OOPdOZJi0fuJ7wuoHGdpRrr0WT8k7KiE5ko6j+ucOpEfFmM1aTRDEjv0zrxfrPcon8gN Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Jul 2013 21:26:14 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2WRQWRTFUJEHNMFAEIMTQ Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 7/26/13 8:09 AM, Jilles Tjoelker wrote: > On Fri, Jul 26, 2013 at 02:00:07AM +0000, Andrey Zonov wrote: >> Author: zont >> Date: Fri Jul 26 02:00:06 2013 >> New Revision: 253662 >> URL: http://svnweb.freebsd.org/changeset/base/253662 >=20 >> Log: >> Remove define and documentation for vm_pageout_algorithm missed in r= 253587 >=20 >> Modified: >> head/lib/libc/gen/sysctl.3 >> head/sys/vm/vm_param.h >> head/tools/tools/sysdoc/tunables.mdoc >=20 >> Modified: head/sys/vm/vm_param.h >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D >> --- head/sys/vm/vm_param.h Fri Jul 26 00:28:19 2013 (r253661) >> +++ head/sys/vm/vm_param.h Fri Jul 26 02:00:06 2013 (r253662) >> @@ -82,9 +82,8 @@ >> #define VM_V_CACHE_MIN 7 /* cnt.v_cache_min */ >> #define VM_V_CACHE_MAX 8 /* cnt.v_cache_max */ >> #define VM_V_PAGEOUT_FREE_MIN 9 /* cnt.v_pageout_free_min */ >> -#define VM_PAGEOUT_ALGORITHM 10 /* pageout algorithm */ >> -#define VM_SWAPPING_ENABLED 11 /* swapping enabled */ >> -#define VM_MAXID 12 /* number of valid vm ids */ >> +#define VM_SWAPPING_ENABLED 10 /* swapping enabled */ >> +#define VM_MAXID 11 /* number of valid vm ids */ >=20 > As noted in mail from Bruce Evans, please preserve the ABI of > VM_SWAPPING_ENABLED here. >=20 I don't think it's a big problem. Internally we don't use it. Good code uses sysctlbyname() instead of sysctl(). It doesn't seem to me this is very popular sysctl. It's also CURRENT without MFC. I prefer clean code where it is possible instead of "dummy" all around. >> #define CTL_VM_NAMES { \ >> { 0, 0 }, \ >> @@ -97,7 +96,6 @@ >> { "v_cache_min", CTLTYPE_UINT }, \ >> { "v_cache_max", CTLTYPE_UINT }, \ >> { "v_pageout_free_min", CTLTYPE_UINT}, \ >> - { "pageout_algorithm", CTLTYPE_INT}, \ >> { "swap_enabled", CTLTYPE_INT},\ >> } >=20 > This should be replaced with some sort of dummy rather than replaced > entirely (does not matter very much because it should not be used). >=20 --=20 Andrey Zonov ------enig2WRQWRTFUJEHNMFAEIMTQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.18 (Darwin) Comment: GPGTools - http://gpgtools.org iQEcBAEBAgAGBQJR8ulzAAoJEBWLemxX/CvTTlMH/AqmYR7Ytm79iDPmZlr4DlDT yQYym8KSY97I6/20E7o4P83j9G8fsbCSnzBF53SfdhsAlB4lENU7sqeMxvvWTlHm 2gQIQ0vXMKUMev+kulVMC/KY53CqCL2Z/akCeny7MwNK2hrUYVFsBjdVQWoDOxrZ fLN2Br1sv+ji4ShcaWYRVnZrYuV8QyfWA4BUssyTM6cPFPHNc/z+ybGNUTPjqt43 dGhudoSyV9IR8ypuutZOlSYHqkGV1+mALS9RLjzMLPnNPUmUqkKC3vtPRFFjc2T5 Ql03zr7VBeos1aRg80Yu1N5sRXV3XwK35imGjTnKmhK9URJPyzc8TNvjoqLzdJY= =fZaL -----END PGP SIGNATURE----- ------enig2WRQWRTFUJEHNMFAEIMTQ--