Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 22 Mar 2023 15:05:44 GMT
From:      Ed Maste <emaste@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: c888b3b22864 - main - sftp: add description of memory leak fix
Message-ID:  <202303221505.32MF5itH076841@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by emaste:

URL: https://cgit.FreeBSD.org/src/commit/?id=c888b3b22864db305fba32839477352c2a756baa

commit c888b3b22864db305fba32839477352c2a756baa
Author:     Ed Maste <emaste@FreeBSD.org>
AuthorDate: 2023-03-21 19:25:01 +0000
Commit:     Ed Maste <emaste@FreeBSD.org>
CommitDate: 2023-03-22 15:04:29 +0000

    sftp: add description of memory leak fix
---
 crypto/openssh/FREEBSD-upgrade | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/crypto/openssh/FREEBSD-upgrade b/crypto/openssh/FREEBSD-upgrade
index 86f4676504fc..78cca746fb77 100644
--- a/crypto/openssh/FREEBSD-upgrade
+++ b/crypto/openssh/FREEBSD-upgrade
@@ -171,7 +171,16 @@
    A number of paths are changed to match FreeBSD's configuration (e.g.,
    using /usr/local/ instead of /uxr/X11R6/).
 
-10) Retired patches
+10) Memory leaks
+
+   Coverity reported a memory leak for which we proposed a fix in
+   https://reviews.freebsd.org/D37253 and sent to the upstream mailing list at
+   https://lists.mindrot.org/pipermail/openssh-unix-dev/2022-November/040497.html
+
+   Upstream subsequently fixed only one of the related leaks, so we reverted
+   the partial fix and applied our change.
+
+11) Retired patches
 
    We no longer have HPN patches (adaptive buffer size for increased
    throughput on high-BxD links) or client-side VersionAddendum, but we



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202303221505.32MF5itH076841>