From owner-svn-src-all@freebsd.org  Thu Feb  4 17:06:05 2016
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 23C16A9C1E3;
 Thu,  4 Feb 2016 17:06:05 +0000 (UTC)
 (envelope-from glebius@FreeBSD.org)
Received: from cell.glebi.us (glebi.us [96.95.210.25])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "cell.glebi.us", Issuer "cell.glebi.us" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id 0F95E1CCF;
 Thu,  4 Feb 2016 17:06:04 +0000 (UTC)
 (envelope-from glebius@FreeBSD.org)
Received: from cell.glebi.us (localhost [127.0.0.1])
 by cell.glebi.us (8.15.2/8.15.2) with ESMTPS id u14H63OV070226
 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);
 Thu, 4 Feb 2016 09:06:03 -0800 (PST)
 (envelope-from glebius@FreeBSD.org)
Received: (from glebius@localhost)
 by cell.glebi.us (8.15.2/8.15.2/Submit) id u14H63Y1070225;
 Thu, 4 Feb 2016 09:06:03 -0800 (PST)
 (envelope-from glebius@FreeBSD.org)
X-Authentication-Warning: cell.glebi.us: glebius set sender to
 glebius@FreeBSD.org using -f
Date: Thu, 4 Feb 2016 09:06:03 -0800
From: Gleb Smirnoff <glebius@FreeBSD.org>
To: Bryan Drewery <bdrewery@FreeBSD.org>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: Re: svn commit: r295226 - head/lib/libmemstat
Message-ID: <20160204170603.GF65294@FreeBSD.org>
References: <201602040023.u140NL0i052392@repo.freebsd.org>
 <56B29E36.8000900@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <56B29E36.8000900@FreeBSD.org>
User-Agent: Mutt/1.5.24 (2015-08-30)
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 04 Feb 2016 17:06:05 -0000

On Wed, Feb 03, 2016 at 04:41:26PM -0800, Bryan Drewery wrote:
B> On 2/3/2016 4:23 PM, Gleb Smirnoff wrote:
B> > Author: glebius
B> > Date: Thu Feb  4 00:23:21 2016
B> > New Revision: 295226
B> > URL: https://svnweb.freebsd.org/changeset/base/295226
B> > 
B> > Log:
B> >   Fix build.
B> > 
B> > Modified:
B> >   head/lib/libmemstat/memstat_uma.c
B> > 
B> > Modified: head/lib/libmemstat/memstat_uma.c
B> > ==============================================================================
B> > --- head/lib/libmemstat/memstat_uma.c	Wed Feb  3 23:41:58 2016	(r295225)
B> > +++ head/lib/libmemstat/memstat_uma.c	Thu Feb  4 00:23:21 2016	(r295226)
B> > @@ -29,6 +29,7 @@
B> >  #include <sys/param.h>
B> >  #include <sys/cpuset.h>
B> >  #include <sys/sysctl.h>
B> > +#include <sys/_task.h>
B> >  
B> >  #include <vm/vm.h>
B> >  #include <vm/vm_page.h>
B> > 
B> 
B> Shouldn't uma_int.h forward declare or include _task.h for struct task?

Forward declaration won't work, since structure is included, not pointed at.
I'm reluctant with adding includes into includes.

-- 
Totus tuus, Glebius.