From owner-freebsd-current@FreeBSD.ORG Fri Sep 21 21:40:27 2007 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7786016A41B; Fri, 21 Sep 2007 21:40:27 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from speedfactory.net (mail6.speedfactory.net [66.23.216.219]) by mx1.freebsd.org (Postfix) with ESMTP id 0BDE713C4C4; Fri, 21 Sep 2007 21:40:26 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (unverified [66.23.211.162]) by speedfactory.net (SurgeMail 3.8p) with ESMTP id 210673077-1834499 for multiple; Fri, 21 Sep 2007 17:22:43 -0400 Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.8/8.13.8) with ESMTP id l8LLOATg064127; Fri, 21 Sep 2007 17:24:12 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: freebsd-acpi@freebsd.org Date: Fri, 21 Sep 2007 17:15:17 -0400 User-Agent: KMail/1.9.6 References: <200709181516.11207.jkim@FreeBSD.org> In-Reply-To: <200709181516.11207.jkim@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200709211715.17940.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Fri, 21 Sep 2007 17:24:12 -0400 (EDT) X-Virus-Scanned: ClamAV 0.88.3/4357/Fri Sep 21 05:55:46 2007 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: freebsd-current@freebsd.org, Jung-uk Kim Subject: Re: [PATCH] OsdSynch.c modernization X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Sep 2007 21:40:27 -0000 On Tuesday 18 September 2007 03:16:07 pm Jung-uk Kim wrote: > I have rewritten sys/dev/acpica/Osd/OsdSynch.c to match the modern > ACPI-CA and -CURRENT: > > http://people.freebsd.org/~jkim/acpica/OsdSynch.diff Why do you use a loop around tsleep() rather than just use sx_xlock() (which will block) for the WAIT_FOREVER case when waiting on a semaphore? Why don't you just use a spin mutex for the spin lock? That is a far better fit than the sx lock stuff you are doing. Manually doing spinlock_enter() (wrongly btw, you should use critical_enter(), not sched_pin() otherwise you can be preempted) just to avoid the assertion failure is just going to result in obscure hangs. Does ACPI-CA want to malloc() while holding an ACPI spin lock or something? -- John Baldwin