From owner-svn-src-head@FreeBSD.ORG Fri Jan 14 15:14:50 2011 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 94440106566B; Fri, 14 Jan 2011 15:14:50 +0000 (UTC) (envelope-from mdf356@gmail.com) Received: from mail-iy0-f182.google.com (mail-iy0-f182.google.com [209.85.210.182]) by mx1.freebsd.org (Postfix) with ESMTP id 3DED18FC0A; Fri, 14 Jan 2011 15:14:49 +0000 (UTC) Received: by iyb26 with SMTP id 26so2678120iyb.13 for ; Fri, 14 Jan 2011 07:14:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=i5dUh9ZhPdqgTOcXugBqjhS4QdHguMD/1pmhHjWgTrU=; b=RBpEioB732w84YWH1BfZWiU8ZObfYKz069z29JaHL7waGaq777cGFfvPQnpnKFJ9lr MPHhGfktmzlosu8zgptTI43xwgSlzSUfIBXWmWf+rFCQ9ZMizfEhkYbxkuOuj+vOwQwz HSpAFCDmOZ/qH2gmGb98ZDsHhx/LFOZ2fk7Ok= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=XFMTpGY2sM+9jEQL1an0k+4VlZ5IDNbeNVYtZV+ruiQUqGa2BI6A4SIQwSQzYMGZc5 n24agZ7hshl6iuCoiTLo8HDK/8N7kULlMwnkyXNlBfT5KA4IF18t2mKfs2pngtRNJICC f3/HExvjcHnAnB5JU9ebOc39WFtXW8qs/Bups= MIME-Version: 1.0 Received: by 10.231.35.141 with SMTP id p13mr797254ibd.79.1295018089443; Fri, 14 Jan 2011 07:14:49 -0800 (PST) Sender: mdf356@gmail.com Received: by 10.231.160.147 with HTTP; Fri, 14 Jan 2011 07:14:49 -0800 (PST) In-Reply-To: <20110114174719.D28159@besplex.bde.org> References: <201101131820.p0DIKXip059402@svn.freebsd.org> <20110114174719.D28159@besplex.bde.org> Date: Fri, 14 Jan 2011 07:14:49 -0800 X-Google-Sender-Auth: U5om4d05EL-3Cxt1O_yTLuWQv6U Message-ID: From: mdf@FreeBSD.org To: Bruce Evans Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r217369 - in head/sys: cam/scsi sys X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Jan 2011 15:14:50 -0000 On Thu, Jan 13, 2011 at 10:50 PM, Bruce Evans wrote: > On Thu, 13 Jan 2011 mdf@freebsd.org wrote: > >> There appear to be 330 uses of SYSCTL and QUAD on the same line in >> CURRENT. =A0This seems reasonable to change them to S64, U64 and X64 so >> they correctly reflect the size they operate upon. >> >> What do y'all think? > > Now I suggest delaying this until they can be renamed to a type- generic > SYSCTL_INT() (would probably need to be spelled differently, SYSCTL_I() > say, even if SYSCTL_INT() was changed at the same time). I'm torn on this one. The compiler knows the type (unless, for SYSCTL_INT, NULL/0 is used, but that is also a compile-time check), but to interpret it requires the use of __builtin_foo which is a gcc extension and not part of standard C. Philosophically, while I like this kind of letting the compiler do the work, if you want C++ you know where to find it. Thanks, matthew