From owner-svn-src-all@FreeBSD.ORG Wed Jan 20 07:08:46 2010 Return-Path: Delivered-To: svn-src-all@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 91B351065670; Wed, 20 Jan 2010 07:08:46 +0000 (UTC) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (nagual.pp.ru [194.87.13.69]) by mx1.freebsd.org (Postfix) with ESMTP id 0A5F08FC13; Wed, 20 Jan 2010 07:08:45 +0000 (UTC) Received: from nagual.pp.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.14.3/8.14.3) with ESMTP id o0K78hX9046016; Wed, 20 Jan 2010 10:08:43 +0300 (MSK) (envelope-from ache@nagual.pp.ru) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=nagual.pp.ru; s=default; t=1263971324; bh=EGShhDyr6nFFK38DjVFXSG35ZXPPbgxErZ8/s+KKRU4=; l=1340; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:In-Reply-To; b=GHfd2kb61ORTP1p2Q/kCwOrHfrUq0yWM+Y1lG3DG5OR2KcEafQqnAmv01qquUF359 xg9BNlHAx3w7rCbnnnMNJrMQSx8NkftSdW/AbiauPAAHIkEJpbUEaTYkONc0quxleC ORmwEbApi1E45Qbnp4sFJbHDNxc6QHkHPe5RoJnI= Received: (from ache@localhost) by nagual.pp.ru (8.14.3/8.14.3/Submit) id o0K78h43046015; Wed, 20 Jan 2010 10:08:43 +0300 (MSK) (envelope-from ache) Date: Wed, 20 Jan 2010 10:08:43 +0300 From: Andrey Chernov To: Bruce Evans Message-ID: <20100120070843.GA45937@nagual.pp.ru> Mail-Followup-To: Andrey Chernov , Bruce Evans , src-committers@FreeBSD.ORG, svn-src-all@FreeBSD.ORG, svn-src-head@FreeBSD.ORG References: <201001181344.o0IDiiEL079037@svn.freebsd.org> <20100120012639.B67517@delplex.bde.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100120012639.B67517@delplex.bde.org> User-Agent: Mutt/1.5.20 (2009-06-14) Cc: svn-src-head@FreeBSD.ORG, svn-src-all@FreeBSD.ORG, src-committers@FreeBSD.ORG Subject: Re: svn commit: r202572 - head/lib/libc/gen X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Jan 2010 07:08:46 -0000 On Wed, Jan 20, 2010 at 01:42:08AM +1100, Bruce Evans wrote: > The comment was correct. It says that POSIX requires strcoll() for > alphasort(), not for opendir(). Since opendir() is not alphasort(), > and it wants plain ASCII sorting to support union file systems, it > intentionally doesn't use either alphasort() or strcoll(). Yes, the comment _alone_ was correct, but its place - isn't. Along with function name containing _alphasort part it makes impression that opendir() uses this type of sort too. BTW, we already have the same correct comment but in the proper place in the scandir.c > Was correct, but it could have been clearer by saying ", so opendir() > uses this comparison function instead of alphasort()". "So", what? The two mentioned things are unrelated and can't be concatenated by "so". > I forget what the old name was. Having alphasort in the name here was > wrong 3 layers deep, since this is not alphasort(), and alphasort() is not > an alpha sorting function -- it is a lexicographically-on-the-whole- > character-set comparison function. Yes. > Correct modulo the name. What name you suggest, opendir_compar()? > New bug in a comment in scandir(): now has an extra blank line, due to > partial removal. Ok, will remove it a bit later. -- http://ache.pp.ru/