From owner-freebsd-embedded@FreeBSD.ORG Thu Sep 5 22:47:35 2013 Return-Path: Delivered-To: freebsd-embedded@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id B3B05358 for ; Thu, 5 Sep 2013 22:47:35 +0000 (UTC) (envelope-from sean_bruno@yahoo.com) Received: from nm20.bullet.mail.bf1.yahoo.com (nm20.bullet.mail.bf1.yahoo.com [98.139.212.179]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 3405A25CE for ; Thu, 5 Sep 2013 22:47:34 +0000 (UTC) Received: from [98.139.215.140] by nm20.bullet.mail.bf1.yahoo.com with NNFMP; 05 Sep 2013 22:47:33 -0000 Received: from [98.139.213.9] by tm11.bullet.mail.bf1.yahoo.com with NNFMP; 05 Sep 2013 22:47:33 -0000 Received: from [127.0.0.1] by smtp109.mail.bf1.yahoo.com with NNFMP; 05 Sep 2013 22:47:33 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s1024; t=1378421253; bh=9T2kL3c85+xqDJ67IPmTYyo5f8HKIQQZrcjVJjtm3Lw=; h=X-Yahoo-Newman-Id:X-Yahoo-Newman-Property:X-YMail-OSG:X-Yahoo-SMTP:X-Rocket-Received:Subject:From:Reply-To:To:Cc:In-Reply-To:References:Content-Type:Date:Message-ID:Mime-Version:X-Mailer; b=ek/EPTspybORYaMzMGNt5gY3I/CYbEsVmnigcGADmh3fqvT1sctDD6xUS+cQN1aeXoMRh3HtoFdrUpAwz06jLzbvVO09Kpf+svV7pPsuMjgO8/c4AGgwNQBkMYZi7ovgNPMnv70V1C5v8huqn5xgngwwCUpyH2rCfOuH1GZJTvY= X-Yahoo-Newman-Id: 523836.81306.bm@smtp109.mail.bf1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: 6pIglfkVM1lNyTb.k6tmhIP67fTDjs6lsjM8TWgNBu7BR5J UCS4RSrinwgzm5pZXVsCNjXxw2tfpZJjb_.Pd1Kx4pWv2cp1Eh3BxBftg_Ee zosK6ssJiFk5xqVjTh_ZRn9DAZ99BUDc80lgx1sI_tK.KGACBypqThVhGAZ0 GXbHbmojbmUEEzgDIHZXmFI4zknzVpPDKvU74szmMqejTRdrL_iltcreWkmm 4lYx5OC8fO5tstdtEMS8JQM05dLpOAkI.eesskOX37.fclSoSF7YuIJJQaDm 76ek81wlP1rJWYIbA2ZirJh8PtMUhWTlhJ4Gqs72J6DPNQup2BFm5aBHcFde 2AI5ZpPif8ALvKvr2jfMSwRrE_H.gEzzdn05OWk_GNRadLjTj1cmII.RAj71 JgOHLF1DaV6PwxPz_GBlx2VCtC8EfqFqdcwZnFRCTzOymyqy.sxNQuYtBIfU bcjDUwh3uwPXd4FbDna2LxSlKhvKk46gQJeUuWqK57VpL8zJ7OJ21Tjr4Fxc TJXIFPYuItXH9ChPjyVMw81eBbMd_6BYVPNdv0aHG3OgaGwJfxbU3s2.kgUO 9fJ3egVu5AWjHnhCOU74m4b0UdwtruN9YfU0uhATjB9NMZeFT4QRxntbxS5E kXGECeiphrqNaFzwmBfrEAUzEmzu3MSYgig9vbAULPhs- X-Yahoo-SMTP: u5BKR6OswBC_iZJVfGRoMkTIpc8pEA4- X-Rocket-Received: from [10.73.160.242] (sean_bruno@209.131.62.116 with ) by smtp109.mail.bf1.yahoo.com with SMTP; 05 Sep 2013 15:47:33 -0700 PDT Subject: Re: off by one error, maxpins From: Sean Bruno To: Warner Losh In-Reply-To: References: <1378420702.1647.18.camel@localhost> Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-Zo4EkIJP+zCyRlLuIRAr" Date: Thu, 05 Sep 2013 15:47:32 -0700 Message-ID: <1378421252.1647.21.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.32.1 FreeBSD GNOME Team Port Cc: freebsd-embedded X-BeenThere: freebsd-embedded@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: sbruno@freebsd.org List-Id: Dedicated and Embedded Systems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Sep 2013 22:47:35 -0000 --=-Zo4EkIJP+zCyRlLuIRAr Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable On Thu, 2013-09-05 at 16:42 -0600, Warner Losh wrote: > Shouldn't npins and/or maxpin just be bumped by 1 instead? >=20 > Warner >=20 > On Sep 5, 2013, at 4:38 PM, Sean Bruno wrote: >=20 > > http://people.freebsd.org/~sbruno/maxpin_plus_one.txt > >=20 It looks like its *intentionally* assigned as the h/w specific (GPIO COUNT) -1 in ar71xx_gpio_pin_max() Userland assumes that this value is a 0-based thing. =20 --=-Zo4EkIJP+zCyRlLuIRAr Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (FreeBSD) iQEcBAABAgAGBQJSKQoEAAoJEBkJRdwI6BaHxrQH/0m3wO1mF4MvA+3+xVAmY4cg P/9hky7zgMo3CKc1aDRGwMa/hAi1haw8RPyEJTrRVdsJHo3eplvPUR7w1CkjWfdO IsS4x/GkiLFf7mIvf207LsbOEwyeZp7FPlhdvNz9DIvzUBfGlMXTYGsgkSN1ccYa wydOZ8DaaGrOr4A4Yp0AKJzxczR6edJ+kcmYN8bGLwmRxFBi8srAsh7lBV4yeGoT fg/KqCUhsln/wLTz+UxVp9D2ctmEOwpzJ5ou5wxlZk05AK0CTaUraPpUcs3Ia9Rg tdip8ZVAwfyPvdKl3eoLpVv4aYogqzrQsRdEiv4OfVTYUX68pe0P81V5pSmxmso= =xos9 -----END PGP SIGNATURE----- --=-Zo4EkIJP+zCyRlLuIRAr--