From nobody Tue Aug 4 22:06:23 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4hF70x3CRBz6nW6W; Tue, 04 Aug 2026 22:06:25 +0000 (UTC) (envelope-from markj@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4hF70x2GZVz3pvd; Tue, 04 Aug 2026 22:06:25 +0000 (UTC) (envelope-from markj@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785881185; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qjX6VjnZtBa2zKRMwm78leNW6nzkPmYhNgoFaSy23PE=; b=QRcrtHVYBqVftKbRSBVFRxL2KxvsI/CaRSsAHCZymPg6I8qNCgQfw2Sp0JU0h1fjbD+VPU ZYTM0ruStN669G5PP/2i8wWD96VtmmFRDw3vChCJNoby3F7pMX2EJI3zz81ZczJ5xOclKw Fl+DBsJbCAAvosVGHMSQtZbY3n7JeqetObcUeU64OpxOQ+Z+vlLVWXoD8kKT3l2jtHboVr We8EAI36GBA50/RXwd/vI93u4yhYf//UMHM2MwhIj9Hf2GdmhPiscRGYQKtBHkXIDi4uJt /C3bIeo84MlurnF40GDysBllq6snNewVlRnEo1UsC8668lRtViIiXo9ZRkZ1PQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1785881185; a=rsa-sha256; cv=none; b=vLvaBKVgh0oOVLFV1A6RPZurFn/U94A5cJx1AUfFwIgJR54w4uobEYkfp//WCGFoPbSliK g19FaPln3WblFbanoP8MZelsDMC6yFy4UKKNjrksFkPmX8VYcVKrxnJLlSgqJMhtwfFfr4 5rdNm/FuacCahJI71Z2JRd2DuRmqwzsi1YeJyqukjhmoG1VXN1Oi8NqmSwT6jPKeYXiXwN ZTkr6XforQBX9aISe6ybaGgzrueAcMEdyOguROlPVMJ1Bs9kl3ASrTMWr/3GDlnQ/sqzEr MM2L3/iE8BHf8067EY8LY5uMAJUzBCFxBqEtqNukhb182ep/rrEhJAassZk00w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1785881185; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qjX6VjnZtBa2zKRMwm78leNW6nzkPmYhNgoFaSy23PE=; b=qVzklIOjLbIBTzloypoSYkP30cbLuPjm/EScedGPxzLFRrCJEj7zHSi7XBAJ0tY/3byDN1 YPcnwxh9MUPPgyUahVFT+mRk6GDZM0jxYNioFMHGBVyhKxOryNL4UuEYRbbG4h4O0fAUab klwt/CHbthBuUh8Ff4e5cnvY83YBeBbHnhyKG1SCN4NWZd1Esx3c7sZiOGqacdTRiXHUiv 2Q7cxytT3LZs9xKzKs6/IxyQniAEh5iy8UhqHBGA5r7TGPzOKZmLCaTF7NAD8aoDBZBCKJ 9YtYi0I6gfRuAbQA8DnfLboLAG0EJidnIylUvpuHvTxAljHUT60CNg/4RGEl1A== Received: from nuc (192-0-220-237.cpe.teksavvy.com [192.0.220.237]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: markj) by smtp.freebsd.org (Postfix) with ESMTPSA id 4hF70w5s4nz188Z; Tue, 04 Aug 2026 22:06:24 +0000 (UTC) (envelope-from markj@freebsd.org) Date: Tue, 4 Aug 2026 18:06:23 -0400 From: Mark Johnston To: Alan Somers Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org, Jitendra Bhati Subject: Re: git: 4bd01d6ae016 - main - fts: refactor to use fd-relative operations internally Message-ID: References: <6a70e844.251cb.6995429f@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Tue, Aug 04, 2026 at 01:33:40PM -0600, Alan Somers wrote: > Try this patch. It works for me. I don't have an ATF regression test > to go with it, though: This fixes the test failures, but I'm still seeing some weirdness when running tests in parallel: one test is doing something which exhausts all of the free vnodes in the kernel, and that causes a bunch of other tests to time out. At some point the system recovers and carries on normally. I'm not sure what the offending test is, but maybe there is a file descriptor leak somewhere in the change, or some problem with the compat implementation? > diff --git a/lib/libc/gen/fts.c b/lib/libc/gen/fts.c > index 204340e4b87f..3dd9b6432a2c 100644 > --- a/lib/libc/gen/fts.c > +++ b/lib/libc/gen/fts.c > @@ -489,8 +489,7 @@ fts_read(FTS *sp) > * FTS_STOP or the fts_info field of the node. > */ > if (sp->fts_child != NULL) { > - if (fts_safe_changedir(sp, p, > - p->fts_dirfd, p->fts_name)) { > + if (fts_safe_changedir(sp, p, -1, p->fts_name)) { > p->fts_errno = errno; > p->fts_flags |= FTS_DONTCHDIR; > for (p = sp->fts_child; p != NULL; > > > On Tue, Aug 4, 2026 at 1:00 PM Alan Somers wrote: > > > > On Tue, Aug 4, 2026 at 12:58 PM Mark Johnston wrote: > > > > > > On Mon, Aug 03, 2026 at 07:13:08PM +0000, Alan Somers wrote: > > > > The branch main has been updated by asomers: > > > > > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=4bd01d6ae01632501b63438b8d9a401db9744a78 > > > > > > > > commit 4bd01d6ae01632501b63438b8d9a401db9744a78 > > > > Author: Jitendra Bhati > > > > AuthorDate: 2026-06-12 17:07:55 +0000 > > > > Commit: Alan Somers > > > > CommitDate: 2026-08-03 19:12:28 +0000 > > > > > > > > fts: refactor to use fd-relative operations internally > > > > > > > > Replace all _open() calls with _openat() in __fts_open(), fts_read(), > > > > and fts_children(). Replace statfs() with _fstatfs(). > > > > > > > > Add fts_dirfd to struct _ftsent, set to the file descriptor of the > > > > parent directory. Callers can use openat(ent->fts_dirfd, ent->fts_name, > > > > ...) to access files safely without relying on fts_accpath, which > > > > enables programs in capability mode to open the files described by > > > > _ftsent. > > > > > > > > This is a preparatory change for fts_openat() which will allow callers > > > > to provide a pre-opened directory fd, enabling fts(3) traversal inside > > > > Capsicum capability mode. > > > > > > > > Mirror all fts_open() changes to fts_open_b(). > > > > > > > > As a result of expanding _ftsend, publish new ELF symbol versions for > > > > fts_openat and related functions. > > > > > > > > Sponsored by: Google LLC (GSoC 2026) > > > > Reviewed by: asomers > > > > Pull Request: https://github.com/freebsd/freebsd-src/pull/2303 > > > > > > Quite a few regression tests seem to be failing after this commit, e.g., > > > some of the makefs tests: https://ci.freebsd.org/job/FreeBSD-main-amd64-test/29201/ > > > > I'm testing a fix now. I should have something ready for you soon. >