From owner-svn-src-head@FreeBSD.ORG  Fri Aug  9 20:39:32 2013
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id B5451E2;
 Fri,  9 Aug 2013 20:39:32 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1])
 (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 8C0B82119;
 Fri,  9 Aug 2013 20:39:32 +0000 (UTC)
Received: from jhbbsd.localnet (unknown [209.249.190.124])
 by bigwig.baldwin.cx (Postfix) with ESMTPSA id 8A0D1B95B;
 Fri,  9 Aug 2013 16:39:31 -0400 (EDT)
From: John Baldwin <jhb@freebsd.org>
To: Alan Cox <alc@rice.edu>
Subject: Re: svn commit: r254150 - head/sys/vm
Date: Fri, 9 Aug 2013 16:39:30 -0400
User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110714-p28; KDE/4.5.5; amd64; ; )
References: <201308091643.r79GhoWx023884@svn.freebsd.org>
 <201308091556.47535.jhb@freebsd.org>
 <DA97389E-DAB5-4DB6-BB52-417CDBBB0BF9@rice.edu>
In-Reply-To: <DA97389E-DAB5-4DB6-BB52-417CDBBB0BF9@rice.edu>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201308091639.30727.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7
 (bigwig.baldwin.cx); Fri, 09 Aug 2013 16:39:31 -0400 (EDT)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org, "David E. O'Brien" <obrien@freebsd.org>
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 09 Aug 2013 20:39:32 -0000

On Friday, August 09, 2013 4:34:36 pm Alan Cox wrote:
> 
> On Aug 9, 2013, at 12:56 PM, John Baldwin wrote:
> 
> > On Friday, August 09, 2013 12:43:50 pm David E. O'Brien wrote:
> >> Author: obrien
> >> Date: Fri Aug  9 16:43:50 2013
> >> New Revision: 254150
> >> URL: http://svnweb.freebsd.org/changeset/base/254150
> >> 
> >> Log:
> >>  Add missing 'VPO_BUSY' from r254141 to fix kernel build break.
> >> 
> >> Modified:
> >>  head/sys/vm/vm_page.h
> > 
> > This can't possibly be correct as r254138 just removed this flag.  If it 
isn't 
> > obvious how to fix the uses added back in r254141, then r254141 should be 
> > reverted instead.
> > 
> > Hmm, looking at the relevant bits of r254141, it doesn't look obvious:
> > 
> > +       /* Detach the old page from the resident tailq. */
> > +       TAILQ_REMOVE(&object->memq, mold, listq);
> > +       vm_page_lock(mold);
> 
> Replace the next four lines with
> 
> 	vm_page_xunbusy(mold);

That is going to recurse on vm_page_lock(), is that ok?

> > +       if (mold->oflags & VPO_BUSY) {
> > +               mold->oflags &= ~VPO_BUSY;
> > +               vm_page_flash(mold);
> > +       }
> > 
> > Since nothing is setting this flag, this can't possibly work correctly 
> > currently.  I wouldn't boot a top-of-tree kernel right now. :(
> > 
> > -- 
> > John Baldwin
> > 
> 
> 

-- 
John Baldwin