From owner-svn-src-head@freebsd.org Thu Apr 16 22:05:40 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 2C91D2C97D8; Thu, 16 Apr 2020 22:05:40 +0000 (UTC) (envelope-from oliver.pntr@gmail.com) Received: from mail-yb1-xb2a.google.com (mail-yb1-xb2a.google.com [IPv6:2607:f8b0:4864:20::b2a]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 493Cw40Ppdz4Bfg; Thu, 16 Apr 2020 22:05:39 +0000 (UTC) (envelope-from oliver.pntr@gmail.com) Received: by mail-yb1-xb2a.google.com with SMTP id h205so2892020ybg.6; Thu, 16 Apr 2020 15:05:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=AcPmcl8gmujn/5WqoGYLiwg8KzYHnqxu1zngmCIrHTM=; b=t/x65eC1Z73eOXlEXrwraNvXkdd/54HbERzsUs8Cf5qbiV6tGgnK1jkSYR6NOy/+Ve FN0cT6WNSMUoUjLF5lGJa/iuJT5UGvKjn5eU5xo4l5VzRc/R+RHiHttj+yaBGS5v8QAI RM3Y8GMBVcBZ1lpCmE78NF6m0l0Hjs3rinSUYzGHE7R/k5CA5/scv/YrnNQtwjZK99DI 4zIqJaTNLvSpe0rLZ2Kabieq6JSTFNTpuR6eyRiX0JTUFiiiRZd+B71sxkH7dhlbRGVC g/9guCJ2HLQe6THdHiAQq+Ifd1kVXWpueeQ6LiGAzuFpwrTwGer3oT560PI6Dtr/R93Z 03Sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=AcPmcl8gmujn/5WqoGYLiwg8KzYHnqxu1zngmCIrHTM=; b=qQ4kMtSzVT1+GAAxCbebKnOJBdQcd1T5ybttclYaHePCIxSCWYJEBPQMuuaZzW01pz fDRJ430IZ8pZrdOYXJkM2UMwmvvzgrNpLWgc3lMK7tRo3o7r/g38Gas5+zDmrst74x1q AxnLUsJdnydxiHh5+j6pIOZtjx16WzXtO7vDtc2iyLEzCqJ90+1uAZII95bMmpLaSOa5 5xyrfxIcu2tE48Dx7L4f//fhcOvkgK0vQQz9sleWm8atWDEqWxJG7gTz4NhPM126r25Z U4x2o2x+DeAEQIB3V68I2wOOlpj6dLlUS1zDKxmLNnE/dxVYayU3GqxZcak0FBjfcdNN lFng== X-Gm-Message-State: AGi0PubGlUvyAuMFEiS/aNJ/+gbfNXA3xGNscJBEckyf+mLv/JEmkIQj Y6RL7Qad+452TFGozXBikLONNimyM+yezZIUoU3Kyw== X-Google-Smtp-Source: APiQypLQgjdUsZZcehn+teSV4C8yJX42l8AMUNPx+Xbsn2ja3b/6OTq0bhixyTkWAsmAIzbvZvyJ6qn+VpuX3roRmf0= X-Received: by 2002:a25:bacd:: with SMTP id a13mr729010ybk.461.1587074738839; Thu, 16 Apr 2020 15:05:38 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a25:7308:0:0:0:0:0 with HTTP; Thu, 16 Apr 2020 15:05:38 -0700 (PDT) In-Reply-To: <202004162156.03GLuqgw058432@repo.freebsd.org> References: <202004162156.03GLuqgw058432@repo.freebsd.org> From: Oliver Pinter Date: Fri, 17 Apr 2020 00:05:38 +0200 Message-ID: Subject: Re: svn commit: r360025 - head/sys/dev/acpica To: Colin Percival Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" X-Rspamd-Queue-Id: 493Cw40Ppdz4Bfg X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-6.00 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Apr 2020 22:05:40 -0000 On Thursday, April 16, 2020, Colin Percival wrote: > Author: cperciva > Date: Thu Apr 16 21:56:52 2020 > New Revision: 360025 > URL: https://svnweb.freebsd.org/changeset/base/360025 > > Log: > Alert devd when acpi_video brightness changes > > On my Dell Latitude 7390 laptop, the brightness hotkeys > (Fn+) send ACPI notifications which acpi_video > handles by adjusting its brightness setting; but ACPI does not > actually do anything with the backlight. > > Announcing brightness changes via devd makes it possible to close > the loop by triggering the intel_backlight utility to perform the > required backlight adjustment. > > Reviewed by: imp > MFC after: 3 days > Differential Revision: https://reviews.freebsd.org/D24424 > > Modified: > head/sys/dev/acpica/acpi_video.c Please add this to release notes! > > Modified: head/sys/dev/acpica/acpi_video.c > ============================================================ > ================== > --- head/sys/dev/acpica/acpi_video.c Thu Apr 16 21:53:17 2020 > (r360024) > +++ head/sys/dev/acpica/acpi_video.c Thu Apr 16 21:56:52 2020 > (r360025) > @@ -1036,6 +1036,7 @@ vo_get_brightness(ACPI_HANDLE handle) > static void > vo_set_brightness(ACPI_HANDLE handle, int level) > { > + char notify_buf[16]; > ACPI_STATUS status; > > ACPI_SERIAL_ASSERT(video_output); > @@ -1043,6 +1044,8 @@ vo_set_brightness(ACPI_HANDLE handle, int level) > if (ACPI_FAILURE(status)) > printf("can't evaluate %s._BCM - %s\n", > acpi_name(handle), AcpiFormatException(status)); > + snprintf(notify_buf, sizeof(notify_buf), "notify=%d", level); > + devctl_notify("ACPI", "Video", "brightness", notify_buf); > } > > static UINT32 > _______________________________________________ > svn-src-head@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/svn-src-head > To unsubscribe, send any mail to "svn-src-head-unsubscribe@freebsd.org" >