From owner-cvs-user  Mon Sep 15 01:44:09 1997
Return-Path: <owner-cvs-user>
Received: (from root@localhost)
          by hub.freebsd.org (8.8.7/8.8.7) id BAA14409
          for cvs-user-outgoing; Mon, 15 Sep 1997 01:44:09 -0700 (PDT)
Received: from GndRsh.aac.dev.com (GndRsh.aac.dev.com [198.145.92.241])
          by hub.freebsd.org (8.8.7/8.8.7) with ESMTP id BAA14392;
          Mon, 15 Sep 1997 01:44:02 -0700 (PDT)
Received: (from rgrimes@localhost) by GndRsh.aac.dev.com (8.8.5/8.7.3) id BAA02444; Mon, 15 Sep 1997 01:43:48 -0700 (PDT)
From: "Rodney W. Grimes" <rgrimes@GndRsh.aac.dev.com>
Message-Id: <199709150843.BAA02444@GndRsh.aac.dev.com>
Subject: Re: cvs commit: src Makefile
In-Reply-To: <199709150830.BAA02397@GndRsh.aac.dev.com> from "Rodney W. Grimes" at "Sep 15, 97 01:30:08 am"
To: rgrimes@GndRsh.aac.dev.com (Rodney W. Grimes)
Date: Mon, 15 Sep 1997 01:43:48 -0700 (PDT)
Cc: bde@zeta.org.au, cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG,
        cvs-user@FreeBSD.ORG, rgrimes@FreeBSD.ORG
X-Mailer: ELM [version 2.4ME+ PL25 (25)]
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: owner-cvs-user@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk

> > >> >  Log:
> > >> >  When calling the src/include Makefile use the shorthand ``all beforeinstall''
> > >> >  inplace of ``all installhdrs symlinks'' so those of us who run with
> > >> >  SHARED=copies get the right results.
> > >> 
> > >> This just undoes rev.1.136 and defeats the point of the installhdrs target,
> > >> which is to support `make install' forcing installation of symlinks here
> > >> (for the temporary include directory for `make world').
> > >> 
> > >> SHARED=copies is the default.
> > >
> > >No, it does not do that.  Take a very careful look, the forcing of
> > 
> > Yes it does.  Of course I looked carefully before commenting.  You broke
> > the main `includes' target.
> 
> No, I fixed the main ``includes'' target, rev 1.136 broke it.  Remeber
> I wrote the original, I maintaine dfor the first 2 years, it should
> NOT forceably do a ``make symlinks'' as it did.  If something is
> broken, it is elsewhere.

Here... this is the patch for the brokeness you think I created:

Index: Makefile
===================================================================
RCS file: /home/ncvs/src/Makefile,v
retrieving revision 1.109.2.16
diff -c -r1.109.2.16 Makefile
*** Makefile	1997/09/15 05:52:04	1.109.2.16
--- Makefile	1997/09/15 08:41:02
***************
*** 250,256 ****
  	@echo "--------------------------------------------------------------"
  	@echo " Rebuilding /usr/include"
  	@echo "--------------------------------------------------------------"
! 	cd ${.CURDIR} && ${BMAKE} includes
  	@echo
  	@echo "--------------------------------------------------------------"
  	@echo " Rebuilding tools needed to build the libraries"
--- 250,256 ----
  	@echo "--------------------------------------------------------------"
  	@echo " Rebuilding /usr/include"
  	@echo "--------------------------------------------------------------"
! 	cd ${.CURDIR} && ${BMAKE} includes SHARED=symlinks
  	@echo
  	@echo "--------------------------------------------------------------"
  	@echo " Rebuilding tools needed to build the libraries"


-- 
Rod Grimes                                      rgrimes@gndrsh.aac.dev.com
Accurate Automation, Inc.                   Reliable computers for FreeBSD