From owner-freebsd-arch@FreeBSD.ORG  Wed Feb 12 02:47:16 2014
Return-Path: <owner-freebsd-arch@FreeBSD.ORG>
Delivered-To: freebsd-arch@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 365E3A0B;
 Wed, 12 Feb 2014 02:47:16 +0000 (UTC)
Received: from mail-qa0-x236.google.com (mail-qa0-x236.google.com
 [IPv6:2607:f8b0:400d:c00::236])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id D86AB1666;
 Wed, 12 Feb 2014 02:47:15 +0000 (UTC)
Received: by mail-qa0-f54.google.com with SMTP id i13so13094160qae.13
 for <multiple recipients>; Tue, 11 Feb 2014 18:47:15 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:sender:date:message-id:subject:from:to:content-type;
 bh=4niL9FfnftPB1j7gfKOyMfw6OrBlF2+ci16hFCF2hJA=;
 b=pQsS3qLDL/90RrgEN3fBHTLoKxtiTRAqwXPcSRRKEzXVaXvcnk/GR+zQ0Imj2W18Y+
 eSPKxjMBagXkihg2B80zJxSM3zmPrncdBwO6EM12yyjML8ZABepFhSey6voYqrC5SXI2
 jR2v8PFJ7o+gzs3cE6x0/LyYE6CUCQlDm0ktUz2MVzUsV8PSwHEOWFsRKgDC92DNisEI
 xWD2HvMMHbhXjxbLmmcgjggfE5AeIjtoNhkLEn9bxRj54gtEOmejJe6BAzW5XVzkkLFR
 iJiPkPhXJzCUTvoT4I/KqpkStc8hOvi2+SSWYfdDrGzXzHllCNCeEXqb5vvv1CPq7XiN
 Jdtw==
MIME-Version: 1.0
X-Received: by 10.224.11.136 with SMTP id t8mr62871475qat.26.1392173234336;
 Tue, 11 Feb 2014 18:47:14 -0800 (PST)
Sender: adrian.chadd@gmail.com
Received: by 10.224.52.8 with HTTP; Tue, 11 Feb 2014 18:47:14 -0800 (PST)
Date: Tue, 11 Feb 2014 18:47:14 -0800
X-Google-Sender-Auth: e3EkuRPK5KGFmk_WZRtv80vt8o8
Message-ID: <CAJ-VmomSiDYUVo5d8ymTpWRW=5_ODTfhnV+iovYc2Hgy7FqLcQ@mail.gmail.com>
Subject: [flowtable] don't insert a flowtable entry if the lle isn't yet valid
From: Adrian Chadd <adrian@freebsd.org>
To: FreeBSD Net <freebsd-net@freebsd.org>, 
 "freebsd-arch@freebsd.org" <freebsd-arch@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
X-BeenThere: freebsd-arch@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Discussion related to FreeBSD architecture <freebsd-arch.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-arch>,
 <mailto:freebsd-arch-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arch/>
List-Post: <mailto:freebsd-arch@freebsd.org>
List-Help: <mailto:freebsd-arch-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
 <mailto:freebsd-arch-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 12 Feb 2014 02:47:16 -0000

Hi,

Some of the collisions stem from the flowtable entry being created and
inserted before the lle has completed - subsequent lookups will fail
the LLE_VALID check, but inserting them will immediately fail due to a
collision.

This patch:

* doesn't insert a flowtable entry until the lle is valid;
* adds a counter to netstat to log when this happens.

http://people.freebsd.org/~adrian/netflix/20140211-flowtable-no-insert-on-arp-not-done.diff

I'd like to commit this to -HEAD and backport it to -10.

Thanks!


-a