From nobody Sun Oct 6 06:30:57 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XLsql0Gg9z5YN72; Sun, 06 Oct 2024 06:31:15 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4XLsqk0T2hz4Qx6; Sun, 6 Oct 2024 06:31:13 +0000 (UTC) (envelope-from kostikbel@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: from tom.home (kib@localhost [127.0.0.1] (may be forged)) by kib.kiev.ua (8.18.1/8.18.1) with ESMTP id 4966UvkC057803; Sun, 6 Oct 2024 09:31:00 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua 4966UvkC057803 Received: (from kostik@localhost) by tom.home (8.18.1/8.18.1/Submit) id 4966Uvwc057802; Sun, 6 Oct 2024 09:30:57 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Sun, 6 Oct 2024 09:30:57 +0300 From: Konstantin Belousov To: Mark Millard Cc: Current FreeBSD , dev-commits-src-main@freebsd.org, Konstantin Belousov Subject: Re: git: 2c1963d46335 - main - procfs rlimit: handle pipebuf [and related] :pipebuf . . . Invalid argument Message-ID: References: <34434D36-A751-477A-8596-72A564113FB8.ref@yahoo.com> <34434D36-A751-477A-8596-72A564113FB8@yahoo.com> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <34434D36-A751-477A-8596-72A564113FB8@yahoo.com> X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on tom.home X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:6939, ipnet:2001:470::/32, country:US] X-Rspamd-Queue-Id: 4XLsqk0T2hz4Qx6 X-Spamd-Bar: ---- On Sat, Oct 05, 2024 at 06:14:40PM -0700, Mark Millard wrote: > Konstantin Belousov wrote on > Date: Fri, 20 Sep 2024 21:09:29 UTC : > > > The branch main has been updated by kib: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=2c1963d46335576d29fe21a4e7b424c47b711ef4 > > > > commit 2c1963d46335576d29fe21a4e7b424c47b711ef4 > > Author: Konstantin Belousov > > AuthorDate: 2024-09-20 15:04:06 +0000 > > Commit: Konstantin Belousov > > CommitDate: 2024-09-20 21:08:51 +0000 > > > > procfs rlimit: handle pipebuf > > > > Sponsored by: The FreeBSD Foundation > > MFC after: 1 week > > --- > > sys/sys/resource.h | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/sys/sys/resource.h b/sys/sys/resource.h > > index c18e45d50b30..81346028f1ed 100644 > > --- a/sys/sys/resource.h > > +++ b/sys/sys/resource.h > > @@ -127,7 +127,7 @@ struct __wrusage { > > */ > > > > #ifdef _RLIMIT_IDENT > > -static const char *rlimit_ident[RLIM_NLIMITS] = { > > +static const char *rlimit_ident[] = { > > "cpu", > > "fsize", > > "data", > > @@ -143,6 +143,7 @@ static const char *rlimit_ident[RLIM_NLIMITS] = { > > "swap", > > "kqueues", > > "umtx", > > + "pipebuf", > > }; > > #endif > > As part of an experiment I just had 1500024 (somewhat after the > libmd.so.{6 -> 7} update) boot with a 1500023 kernel that was > somewhat before the fairly recent pipebuf related changes, such > as the above. This produced a bunch of error messages, such as: > > > . . . > ugen0.7: at usbus0 (disconnected) > Warning: no time-of-day clock registered, system time will not be set accurately > 2024-10-05T17:33:58.032649-07:00 - init 20 - - getting pipebuf resource limit: Invalid argument > . . . > Starting devd. > limits: setrlimit pipebuf: Invalid argument > /etc/rc: WARNING: failed to start devd > Waiting 30s for the default route interface: ............................. > . . . > Starting syslogd. > limits: setrlimit pipebuf: Invalid argument > /etc/rc: WARNING: failed to start syslogd > . . . > Starting rpcbind. > limits: setrlimit pipebuf: Invalid argument > /etc/rc: WARNING: failed to start rpcbind > NFS access cache time=60 > Starting ntpd. > limits: setrlimit pipebuf: Invalid argument > /etc/rc: WARNING: failed to start ntpd > . . . > Starting rpcbind. > limits: setrlimit pipebuf: Invalid argument > /etc/rc.d/mountd: WARNING: Unable to force rpcbind. It may already be running. > Starting mountd. > limits: setrlimit pipebuf: Invalid argument > /etc/rc: WARNING: Unable to force mountd. It may already be running. > /etc/rc: WARNING: failed precmd routine for nfsd > . . . > Starting sshd. > limits: setrlimit pipebuf: Invalid argument > /etc/rc: WARNING: failed to start sshd > Starting cron. > limits: setrlimit pipebuf: Invalid argument > /etc/rc: WARNING: failed to start cron > . . . > 2024-10-06T00:34:50.800786-07:00 aarch64-main-pbase init 1014 - - getting pipebuf resource limit: Invalid argument > 2024-10-06T00:34:50.800858-07:00 aarch64-main-pbase init 1015 - - getting pipebuf resource limit: Invalid argument > 2024-10-06T00:34:50.800939-07:00 aarch64-main-pbase init 1016 - - getting pipebuf resource limit: Invalid argument > 2024-10-06T00:34:50.801101-07:00 aarch64-main-pbase init 1018 - - getting pipebuf resource limit: Invalid argument > 2024-10-06T00:34:50.801090-07:00 aarch64-main-pbase init 1017 - - getting pipebuf resource limit: Invalid argument > 2024-10-06T00:34:50.801240-07:00 aarch64-main-pbase init 1020 - - getting pipebuf resource limit: Invalid argument > 2024-10-06T00:34:50.801250-07:00 aarch64-main-pbase init 1019 - - getting pipebuf resource limit: Invalid argument > 2024-10-06T00:34:50.801406-07:00 aarch64-main-pbase init 1021 - - getting pipebuf resource limit: Invalid argument > ugen0.6: at usbus0 > 2024-10-06T00:35:08.833554-07:00 aarch64-main-pbase login 1014 - - login on ttyv0 as root > 2024-10-06T00:35:08.833623-07:00 aarch64-main-pbase login 1014 - - ROOT LOGIN (root) ON ttyv0 > 2024-10-06T00:35:08.835269-07:00 aarch64-main-pbase login 1022 - - getting pipebuf resource limit: Invalid argument > . . . > > > It seems related changes introducing incompatibility with even > recent older kernels should have had a __FreeBSD_version update > and might need to be documented for the now-existing > incompatibility with most of the 1500023 and older history? We do not provide forward compatibility between kernel and userspace. User binaries must be newer than kernel.