From owner-svn-src-head@freebsd.org Fri Aug 23 11:13:49 2019 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id C859FC15EB; Fri, 23 Aug 2019 11:13:49 +0000 (UTC) (envelope-from eugen@grosbein.net) Received: from hz.grosbein.net (hz.grosbein.net [IPv6:2a01:4f8:c2c:26d8::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "hz.grosbein.net", Issuer "hz.grosbein.net" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 46FJgJ5TXDz4d9m; Fri, 23 Aug 2019 11:13:48 +0000 (UTC) (envelope-from eugen@grosbein.net) Received: from eg.sd.rdtc.ru (eg.sd.rdtc.ru [IPv6:2a03:3100:c:13:0:0:0:5]) by hz.grosbein.net (8.15.2/8.15.2) with ESMTPS id x7NBDiau089852 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 23 Aug 2019 11:13:45 GMT (envelope-from eugen@grosbein.net) X-Envelope-From: eugen@grosbein.net X-Envelope-To: cem@freebsd.org Received: from [10.58.0.4] ([10.58.0.4]) by eg.sd.rdtc.ru (8.15.2/8.15.2) with ESMTPS id x7NBDaKk029892 (version=TLSv1.2 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Fri, 23 Aug 2019 18:13:36 +0700 (+07) (envelope-from eugen@grosbein.net) Subject: Re: svn commit: r351413 - head/usr.bin/last To: cem@freebsd.org References: <201908230125.x7N1PdTN070890@repo.freebsd.org> <361cc2e7-fba5-d724-dcf0-3c4ae3a8ed6f@freebsd.org> Cc: src-committers , svn-src-all , svn-src-head From: Eugene Grosbein Message-ID: <6af6c95a-4978-6898-4191-01e734ccb298@grosbein.net> Date: Fri, 23 Aug 2019 18:13:30 +0700 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <361cc2e7-fba5-d724-dcf0-3c4ae3a8ed6f@freebsd.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=0.3 required=5.0 tests=BAYES_00,LOCAL_FROM, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.2 X-Spam-Report: * -2.3 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record * -0.0 SPF_PASS SPF: sender matches SPF record * 2.6 LOCAL_FROM From my domains X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on hz.grosbein.net X-Rspamd-Queue-Id: 46FJgJ5TXDz4d9m X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=permerror (mx1.freebsd.org: domain of eugen@grosbein.net uses mechanism not recognized by this client) smtp.mailfrom=eugen@grosbein.net X-Spamd-Result: default: False [-4.25 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[grosbein.net]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; RCVD_COUNT_THREE(0.00)[3]; IP_SCORE(-1.24)[ip: (-2.36), ipnet: 2a01:4f8::/29(-1.96), asn: 24940(-1.86), country: DE(-0.01)]; R_SPF_PERMFAIL(0.00)[]; NEURAL_HAM_SHORT(-0.91)[-0.914,0]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:24940, ipnet:2a01:4f8::/29, country:DE]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Aug 2019 11:13:49 -0000 23.08.2019 17:38, Eugene Grosbein wrote: >> Should this be done more generally? Last time I looked it seemed like >> libxo was completely locale-unaware and just assumed all input was >> UTF-8. It might make more sense to have libxo take locale into >> account when formatting %s strings. > > libxo is locale-aware but in its own quite peculiar way, as libxo(3) tells: >> For strings, the 'h' and 'l' modifiers affect the interpretation of the >> bytes pointed to argument. The default '%s' string is a 'char *' pointer >> to a string encoded as UTF-8. Since UTF-8 is compatible with ASCII data, >> a normal 7-bit ASCII string can be used. "%ls" expects a "wchar_t *" >> pointer to a wide-character string, encoded as 32-bit Unicode values. >> "%hs" expects a "char *" pointer to a multi-byte string encoded with the >> current locale, as given by the LC_CTYPE, LANG, or LC_ALL environment >> variables. Sorry, this is from xo_format(5) actually.