From owner-freebsd-acpi@FreeBSD.ORG Wed Mar 18 21:32:16 2015 Return-Path: Delivered-To: freebsd-acpi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id ED9F2D99 for ; Wed, 18 Mar 2015 21:32:15 +0000 (UTC) Received: from mail-ig0-f173.google.com (mail-ig0-f173.google.com [209.85.213.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A9A9CE7B for ; Wed, 18 Mar 2015 21:32:15 +0000 (UTC) Received: by igbud6 with SMTP id ud6so6086240igb.1 for ; Wed, 18 Mar 2015 14:32:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:mime-version:content-type:from :in-reply-to:date:cc:message-id:references:to; bh=b9si3uO6fvm63wwsRGau93/CfAGeb7g/tdkM/utXHTg=; b=kJJX75ELqQnUjugSy4fws/9yDcx5iXmRDCzhx6KUolQnAXSrv5MsVfHdDOuGBUiRbp aetChzNtjXUSOG+vE0vfk3q61p3gIFqyLfK/d+CKVm5jYNQwqgKFUlmmrgCW2v9Zct70 UIxCmz7jS6DIAADyvcRQCFwvVYWeG0+CVuQj9AQltXW0OoC9+2oFzA0nb/sXspItnEPv 02SMoUdxu3rD/wqYi4TWOcjIiAlLtlau9ge5GzGZ4Jx3bP6SYNIFPf7xVcUeUptOF3sH Rslt/2i13dV4ratBWX/RU3Q38MyXpI7EJXvc7Kk7LJMJovToL8nd6jFO1nu8W7KpuFJ4 8enQ== X-Gm-Message-State: ALoCoQk4jWrICy45mFkzshasRhlSApgsrl/hgER6vqZxsQzHUR6ySFlNFLYkbqXw9BxyTTjPXSyj X-Received: by 10.42.236.79 with SMTP id kj15mr7767590icb.40.1426714329527; Wed, 18 Mar 2015 14:32:09 -0700 (PDT) Received: from netflix-mac.bsdimp.com ([50.253.99.174]) by mx.google.com with ESMTPSA id o8sm2571722igp.11.2015.03.18.14.32.08 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 18 Mar 2015 14:32:09 -0700 (PDT) Sender: Warner Losh Subject: Re: [PATCH] ACPI CMOS region support rev. 5 Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2070.6\)) Content-Type: multipart/signed; boundary="Apple-Mail=_A9D859D8-4CD7-4618-9C77-32F238BE7026"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail 2.5b5 From: Warner Losh In-Reply-To: <5509A0EA.4070208@att.net> Date: Wed, 18 Mar 2015 15:32:08 -0600 Message-Id: <85F2CFD2-14C1-43D6-8963-0D1F69F17577@bsdimp.com> References: <20150222180817.GD27984@strugglingcoder.info> <54EB8C21.2080600@att.net> <2401337.2oUs7iAbtB@ralph.baldwin.cx> <54EF3D5D.4010106@att.net> <20150227222203.P38620@sola.nimnet.asn.au> <20150228125857.D1277@besplex.bde.org> <54F14368.4020807@att.net> <20150302002647.W42658@sola.nimnet.asn.au> <54F5E53D.1090601@att.net> <20150306025800.U46361@sola.nimnet.asn.au> <54F9D7E6.4050807@att.net> <5504FF32.3020202@att.net> <20150317001401.X22641@sola.nimnet.asn.au> <5506F00A.3030708@att.net> <5506FBE3.1000009@att.net> <20150317041624.K22641@sola.nimnet.asn.au> <55073442.5060005@att.net> <5509A0EA.4070208@att.net> To: Anthony Jenkins X-Mailer: Apple Mail (2.2070.6) Cc: freebsd-acpi@freebsd.org, Ian Smith X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Mar 2015 21:32:16 -0000 --Apple-Mail=_A9D859D8-4CD7-4618-9C77-32F238BE7026 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=windows-1252 > On Mar 18, 2015, at 9:59 AM, Anthony Jenkins = wrote: >=20 > On 03/18/2015 11:26 AM, Warner Losh wrote: >> Looking at patch 5: >>=20 >> You need to rework this so there=92s an atrtc_acpi.c. Put all the = ACPI attachment in there. >=20 > Okay, shouldn't be a problem. >=20 >> You should also split off the little bit that=92s ISA-specific into = atrtc_isa. >=20 > You mean rtcin() and writertc()? ...but that's not my stuff, it was > already in atrtc.c. PNP0800 (the PC-AT RTC component) is = (practically) > an ISA-specific device. There will be a small =93isa=94 specific driver. Here ISA means =91FreeBSD= ISA attachment=92 not necessarily what you=92d find on an ISA bus. This means you=92d have two = separate driver statement. You can then do the ACPI stuff in the ACPI attachment and not = have to worry about whether or not it is compiled into the kernel, since you=92d only = include it if acpi is in the kernel. Warner --Apple-Mail=_A9D859D8-4CD7-4618-9C77-32F238BE7026 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJVCe7YAAoJEGwc0Sh9sBEAMqEP/RDUi2VmhMFeV7W0+ssMGplt 9/QkjgivDPKvEbWDefm837nI2GY4FlIUIrN8F0r3D7Jr1Ur+NdJPsAimc4uOz/tG UHyG1QgOBG3GB0zuIYSwpJEPZ+ddlWH14vlucCjCoIm8FB1o/TKwHEUdU8OZtPMo 5DplTkwoUXo9vY9iJz+TpiwqR1KXVU5TKN22SrJcdkKLVFPWIpvCc2uXLrtkOp+x OR7v5q+1JxuKBSVSnehMKVeQwPbzBQA93dYswn/4a4kB4IK0oWgxpdHc0SvAt8vz AB/SlBWQySeB9QHQbSGRE8VxvTIFYmMHyAcBTdKS8ohf7JNi0zgHGNUHoer+HmW9 wcXFKR/y7tG6xiIDnH/yXlcQ/eQ3xXed/ZW/hG+cuKfoG8X0kd+bb0nQ99NeYFvG C10OGvew/2fk5yf2AobVtgzdxT3VL2mLGl1hqN6jJnpIfs4zAyOTFT/dg4UnZpIA rWD6mhBUd03GZ2OISEiLtI3m3AsQ4DDsjHRTXcMoa+rgCXISXcroHINax1e4FI5s IjPRfiswlmWFxaLnqoSwYPxfxvMbemeqDN3hCvIv6K6APVIPPGi31yDmL2O07U+R iF9Qvrf2f/g1VCXIkHsti53MV8qGwucUkwTzd4sUqKKPyg+AoNKq1gdcPORjd9qd L5wzrgal1kwpYDdBd7BS =+RsP -----END PGP SIGNATURE----- --Apple-Mail=_A9D859D8-4CD7-4618-9C77-32F238BE7026--