From owner-cvs-all@FreeBSD.ORG Thu Jul 6 22:08:26 2006 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 33A1C16A4E1; Thu, 6 Jul 2006 22:08:26 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9BFF643D46; Thu, 6 Jul 2006 22:08:25 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.4/8.13.4) with ESMTP id k66M8L9d012110; Thu, 6 Jul 2006 18:08:22 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Scott Long Date: Thu, 6 Jul 2006 18:08:15 -0400 User-Agent: KMail/1.9.1 References: <200607062142.k66LgaoV050809@repoman.freebsd.org> <44AD8667.9090600@samsco.org> In-Reply-To: <44AD8667.9090600@samsco.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200607061808.16440.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Thu, 06 Jul 2006 18:08:22 -0400 (EDT) X-Virus-Scanned: ClamAV 0.87.1/1586/Wed Jul 5 15:22:07 2006 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.1.0 X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on server.baldwin.cx Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/amd64/linux32 syscalls.master src/sys/compat/linux linux_ioctl.c src/sys/i386/linux syscalls.master X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Jul 2006 22:08:26 -0000 On Thursday 06 July 2006 17:53, Scott Long wrote: > John Baldwin wrote: > > jhb 2006-07-06 21:42:36 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/amd64/linux32 syscalls.master > > sys/compat/linux linux_ioctl.c > > sys/i386/linux syscalls.master > > Log: > > - Protect the list of linux ioctl handlers with an sx lock. > > - Hold Giant while calling linux ioctl handlers for now as they aren't all > > known to be MPSAFE yet. > > - Mark linux_ioctl() MPSAFE. > > > > Revision Changes Path > > 1.15 +1 -1 src/sys/amd64/linux32/syscalls.master > > 1.137 +17 -0 src/sys/compat/linux/linux_ioctl.c > > 1.72 +1 -1 src/sys/i386/linux/syscalls.master > > Why not add the small bit of infrastucture so that modules can declare > their handlers as MPSAFE or not? There are certainly some drivers that > would benefit from this. We can certainly do that. I'm up to at least 3 places that this could be done now: - module event handlers - sysinit's - linux_ioctl handlers For now my focus is on eliminating syscall mpsafe flag, and most syscalls can be made Giant free at this point, but for a few Giant is just being pushed part of the way in. -- John Baldwin