From owner-svn-src-head@freebsd.org  Thu Jul  9 16:28:37 2015
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 161A7996C95;
 Thu,  9 Jul 2015 16:28:37 +0000 (UTC) (envelope-from eri@FreeBSD.org)
Received: from repo.freebsd.org (repo.freebsd.org
 [IPv6:2001:1900:2254:2068::e6a:0])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 063E0105B;
 Thu,  9 Jul 2015 16:28:37 +0000 (UTC) (envelope-from eri@FreeBSD.org)
Received: from repo.freebsd.org ([127.0.1.70])
 by repo.freebsd.org (8.14.9/8.14.9) with ESMTP id t69GSade041688;
 Thu, 9 Jul 2015 16:28:36 GMT (envelope-from eri@FreeBSD.org)
Received: (from eri@localhost)
 by repo.freebsd.org (8.14.9/8.14.9/Submit) id t69GSaFX041687;
 Thu, 9 Jul 2015 16:28:36 GMT (envelope-from eri@FreeBSD.org)
Message-Id: <201507091628.t69GSaFX041687@repo.freebsd.org>
X-Authentication-Warning: repo.freebsd.org: eri set sender to eri@FreeBSD.org
 using -f
From: Ermal Luçi <eri@FreeBSD.org>
Date: Thu, 9 Jul 2015 16:28:36 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: svn commit: r285325 - head/sys/netinet
X-SVN-Group: head
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 09 Jul 2015 16:28:37 -0000

Author: eri
Date: Thu Jul  9 16:28:36 2015
New Revision: 285325
URL: https://svnweb.freebsd.org/changeset/base/285325

Log:
  Correct issue presented in r285051,
  apparently neither clang nor gcc complain about this.
  But clang intis the var to NULL correctly while gcc on at least mips does not.
  Correct the undefined behavior by initializing the variable properly.
  
  PR:		201371
  Differential Revision:	 https://reviews.freebsd.org/D3036
  Reviewed by:	gnn
  Approved by:	gnn(mentor)

Modified:
  head/sys/netinet/ip_input.c

Modified: head/sys/netinet/ip_input.c
==============================================================================
--- head/sys/netinet/ip_input.c	Thu Jul  9 16:13:05 2015	(r285324)
+++ head/sys/netinet/ip_input.c	Thu Jul  9 16:28:36 2015	(r285325)
@@ -941,7 +941,8 @@ ip_forward(struct mbuf *m, int srcrt)
 	if (ro.ro_rt != NULL) {
 		ia = ifatoia(ro.ro_rt->rt_ifa);
 		ifa_ref(&ia->ia_ifa);
-	}
+	} else
+		ia = NULL;
 #ifndef IPSEC
 	/*
 	 * 'ia' may be NULL if there is no route for this destination.