From nobody Wed Apr 22 12:37:24 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4g0zJP0yYlz6ZRPF for ; Wed, 22 Apr 2026 12:37:25 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4g0zJN5qHCz3Gg6 for ; Wed, 22 Apr 2026 12:37:24 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1776861444; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=sXszAcPUgN7jcfp1EL56giQKbWVxGItHcqbH82c4VWY=; b=U6bqai5cLDwezk1mg1VfHfzY9SdcRG9M0iDPeMA7/BcEkerbHNFCuL3HOLgfv40fEPIyFV EknqrsnYgE0MXfrx46UWIjFRLurEuVyjWkNxWJfXHF6HZL4CuSq9n3QTYux9ZRLw70SKoN GzOYobGHgX6htYW/7uY07BexWqItpyeRO8hgwINMdYDuUZlctySiFBTVVSZc+epIxIR6xa iJawDObS4nMlFfBSbglDsqlT8wGlcGccqMF9yPzgZEUkwPMOVR7d9kRLN1rJ8e/oZyjHoz QuI3SirVKRkhaTw5Gz46QI10X96IppcEompYbdV902meI34cMnyRn83969UPfA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1776861444; a=rsa-sha256; cv=none; b=Z0f7lF5MdF7YQtQntbFfADgeZWyc9qtmH3iWaHBo+T1YPmNypt+5mJuubKgCNKVPn9T4dF L/IW6M6oRj09yQyZtDHSZp+1NWjTZIvHd7rlqVFfiVdpwfuwdVd2Zjv10XvYtJ3wGdBuuq h4649vOvpPSRaLe4njmBihgJtVHUrI1KYJ9Xi1MIahPy/KcZjchypdy8Yw1GT/6F7eOSdf UWPcBaZFWG8tbLzMzmEeIa1z6fC2CaBTcUHtU/JIwmvlMSxc0YPv6xfWsmDzr+x12w4KL8 WmKlgjW8kMLqJMe1l8UzH1aZR7wDQY2wKhDRuVKFLYPOa/HkqAUiLIqVbtZkyw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1776861444; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=sXszAcPUgN7jcfp1EL56giQKbWVxGItHcqbH82c4VWY=; b=KXzoc+KtfnI2wjXnnTPqanMlUWiDECkLfiXjtehXn3qbJcxIYKkZ8kZRPczaAfOiXXnXO/ nAk7toxBOKu5tinWoYBnYh4IADy0OtQdWI/LcQr9NDYluI1TiUpPHYEEvrpeK0QB/1Db1/ wiVJFAxWa56FgilVtj94ExafEVx9/qW6JGQ/4x65MXOrYdsrBUYcIehtnWN20OAr4Fm1fH tmIuQ+Uq7zZpbs/AEg3OOzie/X8+D71w8u9DCpDP92MnltHozaz8VekyFL8/ZYZ2nv1lIP IzaxpcOf9TjTqPO/fcb665QRMh64K+oUrgHVV5wcpz+gGvC9EFLDBHTherpNEw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4g0zJN5QBmzVpn for ; Wed, 22 Apr 2026 12:37:24 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 47fb6 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 22 Apr 2026 12:37:24 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Mark Johnston Subject: git: 827dccf3ff5c - stable/15 - linuxkpi: Fix an off-by-one error in the kfifo implementation List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: 827dccf3ff5c48b2f62378a44f58bf287fe99550 Auto-Submitted: auto-generated Date: Wed, 22 Apr 2026 12:37:24 +0000 Message-Id: <69e8c104.47fb6.2e7d9faf@gitrepo.freebsd.org> The branch stable/15 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=827dccf3ff5c48b2f62378a44f58bf287fe99550 commit 827dccf3ff5c48b2f62378a44f58bf287fe99550 Author: Mark Johnston AuthorDate: 2026-04-15 13:33:04 +0000 Commit: Mark Johnston CommitDate: 2026-04-22 12:37:07 +0000 linuxkpi: Fix an off-by-one error in the kfifo implementation "total" is the number of slots in the array, so wraparound needs to be done when "first" or "last" is greater than or equal to the number of slots. Note that no consumers of the code are currently connected to the kernel build. Reported by: Stanislav Fort Reviewed by: bz, emaste MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D56371 (cherry picked from commit 52d2fc702b85d56b35f8828fe7efca3cde0d25b7) --- sys/compat/linuxkpi/common/include/linux/kfifo.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/compat/linuxkpi/common/include/linux/kfifo.h b/sys/compat/linuxkpi/common/include/linux/kfifo.h index d2f570781661..b9f6ecacd3d1 100644 --- a/sys/compat/linuxkpi/common/include/linux/kfifo.h +++ b/sys/compat/linuxkpi/common/include/linux/kfifo.h @@ -71,7 +71,7 @@ (_kf)->head[(_kf)->last] = (_e); \ (_kf)->count++; \ (_kf)->last++; \ - if ((_kf)->last > (_kf)->total) \ + if ((_kf)->last >= (_kf)->total) \ (_kf)->last = 0; \ _rc = true; \ } \ @@ -89,7 +89,7 @@ *(_e) = (_kf)->head[(_kf)->first]; \ (_kf)->count--; \ (_kf)->first++; \ - if ((_kf)->first > (_kf)->total) \ + if ((_kf)->first >= (_kf)->total) \ (_kf)->first = 0; \ _rc = true; \ } \