From owner-svn-src-all@FreeBSD.ORG  Wed Dec 21 22:07:50 2011
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id F13EE1065675;
	Wed, 21 Dec 2011 22:07:50 +0000 (UTC)
	(envelope-from adrian.chadd@gmail.com)
Received: from mail-vx0-f182.google.com (mail-vx0-f182.google.com
	[209.85.220.182])
	by mx1.freebsd.org (Postfix) with ESMTP id 547458FC1A;
	Wed, 21 Dec 2011 22:07:50 +0000 (UTC)
Received: by vcbfk1 with SMTP id fk1so10677864vcb.13
	for <multiple recipients>; Wed, 21 Dec 2011 14:07:49 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=mime-version:sender:in-reply-to:references:date
	:x-google-sender-auth:message-id:subject:from:to:cc:content-type;
	bh=gWVDyTu8QT1JEIIMm5xnjCqI4F49O3bgJ+qKnmwoO7U=;
	b=H3qOKZ1kMMtuHvXvndvZQy+ys8TDRSeh2p3ctNHwPSLdSLL6oPEX8ZqY6UNQQe40t9
	HsjukqjEs//JPQX2y4bhSfbD3ZhrGKaCxjh0OqnYyr0bh++YZjAzC5c7u4uLLxMcN8A2
	PXJIpahThItOUBziEiDbMCWu6Z1WYgE7p1tl4=
MIME-Version: 1.0
Received: by 10.220.232.10 with SMTP id js10mr6185709vcb.2.1324505269686; Wed,
	21 Dec 2011 14:07:49 -0800 (PST)
Sender: adrian.chadd@gmail.com
Received: by 10.52.158.104 with HTTP; Wed, 21 Dec 2011 14:07:49 -0800 (PST)
In-Reply-To: <201112211700.42772.jhb@freebsd.org>
References: <201112211716.pBLHGhDH078507@svn.freebsd.org>
	<CAJ-Vmont2wOF=TkT1CmZt4Gp0iOc7ZYmfQpjW=8j1=F5DQGNwQ@mail.gmail.com>
	<201112211700.42772.jhb@freebsd.org>
Date: Wed, 21 Dec 2011 14:07:49 -0800
X-Google-Sender-Auth: zITTYWdgukXCc2FJNS1KPz9hKtA
Message-ID: <CAJ-Vmo=Mcy1pV0=8guqHayNH=mWGv09K1tXdN=09zk702CebBg@mail.gmail.com>
From: Adrian Chadd <adrian@freebsd.org>
To: John Baldwin <jhb@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org, Dimitry Andric <dim@freebsd.org>
Subject: Re: svn commit: r228785 - in head/sys/dev/ath/ath_hal: ar5210 ar5211
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 21 Dec 2011 22:07:51 -0000

On 21 December 2011 14:00, John Baldwin <jhb@freebsd.org> wrote:

> I agree it should be reviewed, but if you are seriously depending on
> the fact that the shifted values are beyond the edge of the word boundary
> and so the result "wraps" to zero, then I'd question the sanity of your code.

I agree, but this is all "there be dragons" :)


adrian