From owner-svn-ports-head@FreeBSD.ORG  Mon Feb 10 07:21:17 2014
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 116602D3;
 Mon, 10 Feb 2014 07:21:17 +0000 (UTC)
Received: from shepard.synsport.net (mail.synsport.com [208.69.230.148])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id D70891C66;
 Mon, 10 Feb 2014 07:21:16 +0000 (UTC)
Received: from [192.168.0.22] (unknown [130.255.19.191])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by shepard.synsport.net (Postfix) with ESMTP id 899C7435C7;
 Mon, 10 Feb 2014 01:12:04 -0600 (CST)
Message-ID: <52F87BB2.3070402@marino.st>
Date: Mon, 10 Feb 2014 08:11:46 +0100
From: John Marino <freebsd.contact@marino.st>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
 rv:17.0) Gecko/20130509 Thunderbird/17.0.6
MIME-Version: 1.0
To: Steve Wills <swills@FreeBSD.org>
Subject: Re: svn commit: r343559 - head/net-p2p/litecoin
References: <201402092329.s19NTHiq089517@svn.freebsd.org>
 <20140210011718.GA79272@mouf.net>
In-Reply-To: <20140210011718.GA79272@mouf.net>
X-Enigmail-Version: 1.6
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: svn-ports-head@FreeBSD.org, svn-ports-all@FreeBSD.org,
 John Marino <marino@FreeBSD.org>, ports-committers@FreeBSD.org
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
Reply-To: marino@freebsd.org
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 10 Feb 2014 07:21:17 -0000

On 2/10/2014 02:17, Steve Wills wrote:
> On Sun, Feb 09, 2014 at 11:29:17PM +0000, John Marino wrote:
>> Author: marino
>> Date: Sun Feb  9 23:29:16 2014
>> New Revision: 343559
>> URL: http://svnweb.freebsd.org/changeset/ports/343559
>> QAT: https://qat.redports.org/buildarchive/r343559/
>>
>> Log:
>>   net-p2p/litecoin: Fix DragonFly (broken by OSVERSION)
>>   
>>   Limit OSVERSION-based modifications to FreeBSD.  This port suddenly
>>   broken and the use of OSVERSION without OPSYS was the cause.
>>
>> Modified:
>>   head/net-p2p/litecoin/Makefile
>>
>> Modified: head/net-p2p/litecoin/Makefile
>> ==============================================================================
>> --- head/net-p2p/litecoin/Makefile	Sun Feb  9 23:18:17 2014	(r343558)
>> +++ head/net-p2p/litecoin/Makefile	Sun Feb  9 23:29:16 2014	(r343559)
>> @@ -75,7 +75,7 @@ QMAKE_USE_DBUS=	0
>>  PLIST_FILES+=	share/applications/litecoin-qt.desktop share/pixmaps/litecoin64.png
>>  .endif
>>  
>> -.if ${OSVERSION} >= 1000054
>> +.if ${OPSYS} == FreeBSD && ${OSVERSION} >= 1000054
>>  EXTRA_PATCHES+=	${FILESDIR}/extra-patch-endian
>>  .endif
>>  
> 
> Shouldn't this have required maintainer approval? Or am I confused?
> 

According to _my_ interpretation of the "just fix it" blanket, no.  This
is on par with a typographical error.  The cause of the recent breakage
is obvious, the fix is obvious, there's no reason for the maintainer to
object.  Why would an OSVERSION fix require the formality of maintainer
approval?

John