From owner-freebsd-bugs@FreeBSD.ORG  Fri Oct 12 14:20:00 2012
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id 9C711B6C
 for <freebsd-bugs@hub.freebsd.org>; Fri, 12 Oct 2012 14:20:00 +0000 (UTC)
 (envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [8.8.178.135])
 by mx1.freebsd.org (Postfix) with ESMTP id 73BFB8FC0C
 for <freebsd-bugs@hub.freebsd.org>; Fri, 12 Oct 2012 14:20:00 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
 by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q9CEK0LP018431
 for <freebsd-bugs@freefall.freebsd.org>; Fri, 12 Oct 2012 14:20:00 GMT
 (envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
 by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q9CEK0CE018430;
 Fri, 12 Oct 2012 14:20:00 GMT (envelope-from gnats)
Resent-Date: Fri, 12 Oct 2012 14:20:00 GMT
Resent-Message-Id: <201210121420.q9CEK0CE018430@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org,
 Erik Cederstrand <erik@cederstrand.dk>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id 2398FB4B
 for <freebsd-gnats-submit@FreeBSD.org>; Fri, 12 Oct 2012 14:18:18 +0000 (UTC)
 (envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
 by mx1.freebsd.org (Postfix) with ESMTP id 0D6708FC08
 for <freebsd-gnats-submit@FreeBSD.org>; Fri, 12 Oct 2012 14:18:18 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
 by red.freebsd.org (8.14.5/8.14.5) with ESMTP id q9CEIHLq092612
 for <freebsd-gnats-submit@FreeBSD.org>; Fri, 12 Oct 2012 14:18:17 GMT
 (envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
 by red.freebsd.org (8.14.5/8.14.5/Submit) id q9CEIHK7092611;
 Fri, 12 Oct 2012 14:18:17 GMT (envelope-from nobody)
Message-Id: <201210121418.q9CEIHK7092611@red.freebsd.org>
Date: Fri, 12 Oct 2012 14:18:17 GMT
From: Erik Cederstrand <erik@cederstrand.dk>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-3.1
Subject: misc/172639: usr.bin/awk: mark FATAL() as __noreturn__
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 12 Oct 2012 14:20:00 -0000


>Number:         172639
>Category:       misc
>Synopsis:       usr.bin/awk: mark FATAL() as __noreturn__
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Oct 12 14:20:00 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator:     Erik Cederstrand
>Release:        CURRENT
>Organization:
>Environment:
>Description:
This is similar to misc/172636. awk has a function FATAL() that unconditionally calls exit(). Mark it as such in the header prototype.
>How-To-Repeat:

>Fix:
See patch

Patch attached with submission follows:

Index: head/contrib/one-true-awk/proto.h
===================================================================
--- head/contrib/one-true-awk/proto.h	(revision 241481)
+++ head/contrib/one-true-awk/proto.h	(working copy)
@@ -132,7 +132,7 @@
 extern	void	bracecheck(void);
 extern	void	bcheck2(int, int, int);
 extern	void	SYNTAX(const char *, ...);
-extern	void	FATAL(const char *, ...);
+extern	void	FATAL(const char *, ...) __attribute__ ((__noreturn__));
 extern	void	WARNING(const char *, ...);
 extern	void	error(void);
 extern	void	eprint(void);


>Release-Note:
>Audit-Trail:
>Unformatted: