From owner-cvs-src@FreeBSD.ORG Mon Feb 5 12:54:18 2007 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 1BA5F16A403; Mon, 5 Feb 2007 12:54:18 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.sick.ru (cell.sick.ru [217.72.144.68]) by mx1.freebsd.org (Postfix) with ESMTP id 8B9DA13C491; Mon, 5 Feb 2007 12:54:17 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.sick.ru (glebius@localhost [127.0.0.1]) by cell.sick.ru (8.13.4/8.13.3) with ESMTP id l15CsCqS003974 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 5 Feb 2007 15:54:13 +0300 (MSK) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.sick.ru (8.13.4/8.13.1/Submit) id l15CsCIC003973; Mon, 5 Feb 2007 15:54:12 +0300 (MSK) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.sick.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Mon, 5 Feb 2007 15:54:12 +0300 From: Gleb Smirnoff To: Eygene Ryabinkin Message-ID: <20070205125412.GH1621@FreeBSD.org> References: <200702030257.l132vkfT089439@repoman.freebsd.org> <20070205124332.GG1621@FreeBSD.org> <20070205125244.GO35552@codelabs.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <20070205125244.GO35552@codelabs.ru> User-Agent: Mutt/1.5.6i Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Bruce M Simpson , cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/net if_tap.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Feb 2007 12:54:18 -0000 On Mon, Feb 05, 2007 at 03:52:44PM +0300, Eygene Ryabinkin wrote: E> > btw, we have a strange situation with handling off non-broadcast E> > frames not destined to us in general. E> > E> > In a case, when we have generic Ethernet in promisc, and received foreign E> > packets (on a hub, or a buggy switch), they are forwarded to ether_demux() E> > and to upper layers respectively. Isn't this incorrect? E> > E> > Moreover, in case of promisc + net.inet.ip.forwarding=1 our box will resend E> > all the received foreign packets :( E> > E> > What do you think about checking that (ether_dhost == ours || BCAST || MCAST) E> > before sending packet to ether_demux? E> E> If you will do so, please, do not forget to check if we're doing E> bridging, because your proposal will break it. If I understand the E> things correctly ;)) Don't worry. The bridge input is before ether_demux(). -- Totus tuus, Glebius. GLEBIUS-RIPN GLEB-RIPE