From nobody Tue Feb 10 00:46:48 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4f92vF0smsz6R52J for ; Tue, 10 Feb 2026 00:46:49 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4f92vF00DWz4FtG for ; Tue, 10 Feb 2026 00:46:49 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770684409; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=0Lh3xbuqqlgyVjqXm+M7X7ODQOwBHEgaBPm4AIHEgC4=; b=UK5lW/RLziVy3jXrZ7tNoy/VXJ21DJvTfUWCb27H5Z56Gbhb/zv/U3HlXaJua/u+alcFsm ycfSFeiN9G8wtbZfgV0M5kPRwEUS+dWD6oYEqWiQVyUJ8UQpAj8ztP3r5s2zDUUGmgEJCo bmvbs9S6RLY14gwlfA0fYQomut/lKrNTQApICuyr6NWF+BE8deqpedKCKC5vMp7zslgPaU gg00LXAwIz9CAmG1TLwW69lughZRwh5MRDz0GQL5BRi9oLe/0OJzm+O4jv/C7WndpjN/zh IyVRM+ZcoEpgzjWlpJ8IZEHy62PAJETcBMrQik+hdINMO0Djhv5+BIi45CoGFg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1770684409; a=rsa-sha256; cv=none; b=I7XY9Ph8OYWpYXvYY3hiM7h5hqncYx7E2aWFtdo1aoh5mQDrdyHUiWT2sjDmBcC2KgTgOx ptoXOKf0EzsK3pzRZAiUEbZzQFfGJc9FQ5u4H+WiAMIGOXdpHS87jRbSMkOC8J2cXChz7L fZfVI0onEaQBiea5nYnMdi5Sr1NdbuFOXDfbnZZiHHIBDqPA6E6OeivfEeGQ/rGX5+pYsB yYkAv1QVq5VWq17Cjo57KoiyqFbTq9bXOu2KdVsdIOi8Iee0g6gIc+47S9zuNkM13iA21G Wt+P1/Opb8RJxBUVxOw4T7Z3D2TGk+TMVNBOGv7GinbMlMZD+Uxiou2z0mDjgA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770684409; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=0Lh3xbuqqlgyVjqXm+M7X7ODQOwBHEgaBPm4AIHEgC4=; b=jRGVVF4g0tJKl0oEYb1vlmH8Afeun21UX05pWRSU1dPHPx351eKDNSi+bLWlNyJHaZ0gfP D9bL1TDH217KB4PC3fsUHUcjI4R4/LIPiCdcapuNecRkhYckcRUnsTflRlBFURd6rpl3ZZ V36aAIEua/yA1paVue8OHChu+Cn2hDbzWIz7LX70e1nxvWxpaRTMlQQs7GSjb2rm7mCV0K bwm6y0/wN0uw55EeXoY9Gw9QiS5wvh+xHYhNeiqxlRJPmMY5Yj5zlDxLfgOO1CCHXcV76W LAfk2dvS8IHNyJ0tbb0GE+oOgmRtLe/k5xUoKwBf+k/RAKwQqpnGOkGtgvMO7A== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4f92vD6gtFzwYy for ; Tue, 10 Feb 2026 00:46:48 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3152a by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Tue, 10 Feb 2026 00:46:48 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Bjoern A. Zeeb Subject: git: 6387c1135921 - main - ath10k: fix a schedule() call List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: bz X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 6387c1135921fbc86ab0f3c1508a3719ca9cac54 Auto-Submitted: auto-generated Date: Tue, 10 Feb 2026 00:46:48 +0000 Message-Id: <698a7ff8.3152a.5222f675@gitrepo.freebsd.org> The branch main has been updated by bz: URL: https://cgit.FreeBSD.org/src/commit/?id=6387c1135921fbc86ab0f3c1508a3719ca9cac54 commit 6387c1135921fbc86ab0f3c1508a3719ca9cac54 Author: Bjoern A. Zeeb AuthorDate: 2025-12-08 00:00:05 +0000 Commit: Bjoern A. Zeeb CommitDate: 2026-02-09 21:49:45 +0000 ath10k: fix a schedule() call Using kern_yield does not seem ideal either for polling here; use a schedule_timeout() call from LinuxKPI instead and use about 100 iterations per second. Improve an error message to include the error code so we have a better idea of what happens. MFC after: 3 days --- sys/contrib/dev/athk/ath10k/bmi.c | 5 +++++ sys/contrib/dev/athk/ath10k/pci.c | 7 +++++-- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/sys/contrib/dev/athk/ath10k/bmi.c b/sys/contrib/dev/athk/ath10k/bmi.c index 6dd92d29f631..30dded5b6bbb 100644 --- a/sys/contrib/dev/athk/ath10k/bmi.c +++ b/sys/contrib/dev/athk/ath10k/bmi.c @@ -66,7 +66,12 @@ int ath10k_bmi_get_target_info(struct ath10k *ar, ret = ath10k_hif_exchange_bmi_msg(ar, &cmd, cmdlen, &resp, &resplen); if (ret) { +#if defined(__linux__) ath10k_warn(ar, "unable to get target info from device\n"); +#elif defined(__FreeBSD__) + ath10k_warn(ar, "unable to get target info from device: %d\n", + ret); +#endif return ret; } diff --git a/sys/contrib/dev/athk/ath10k/pci.c b/sys/contrib/dev/athk/ath10k/pci.c index e613eaf24797..e9b8573a698b 100644 --- a/sys/contrib/dev/athk/ath10k/pci.c +++ b/sys/contrib/dev/athk/ath10k/pci.c @@ -2340,8 +2340,11 @@ static int ath10k_pci_bmi_wait(struct ath10k *ar, #if defined(__linux__) schedule(); #elif defined(__FreeBSD__) - /* Using LinuxKPI we'll hang for-ever as there's no wake_up */ - kern_yield(PRI_USER); + /* + * Using LinuxKPI's schedule() will hang for-ever as there is + * no wake_up. Poll about 100 times per second until timeout. + */ + schedule_timeout(BMI_COMMUNICATION_TIMEOUT_HZ/300); #endif }