From owner-freebsd-ports@freebsd.org  Sun Aug 23 20:14:36 2020
Return-Path: <owner-freebsd-ports@freebsd.org>
Delivered-To: freebsd-ports@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id 8B8963C90B2
 for <freebsd-ports@mailman.nyi.freebsd.org>;
 Sun, 23 Aug 2020 20:14:36 +0000 (UTC) (envelope-from pi@freebsd.org)
Received: from home.opsec.eu (home.opsec.eu [IPv6:2001:14f8:200::1])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256)
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 4BZRLN1ldYz4QhW
 for <freebsd-ports@freebsd.org>; Sun, 23 Aug 2020 20:14:36 +0000 (UTC)
 (envelope-from pi@freebsd.org)
Received: from pi by home.opsec.eu with local (Exim 4.92.3 (FreeBSD))
 (envelope-from <pi@freebsd.org>) id 1k9wNl-000J4T-6G
 for freebsd-ports@freebsd.org; Sun, 23 Aug 2020 22:14:25 +0200
Date: Sun, 23 Aug 2020 22:14:25 +0200
From: Kurt Jaeger <pi@freebsd.org>
To: freebsd-ports@freebsd.org
Subject: Re: x11-wm/piewm: "ld: error: duplicate symbol: yylineno"
Message-ID: <20200823201425.GL3539@home.opsec.eu>
References: <20200823193504.GB5141@albert.catwhisker.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200823193504.GB5141@albert.catwhisker.org>
X-Rspamd-Queue-Id: 4BZRLN1ldYz4QhW
X-Spamd-Bar: /
Authentication-Results: mx1.freebsd.org;
	none
X-Spamd-Result: default: False [0.00 / 15.00];
 local_wl_from(0.00)[freebsd.org];
 ASN(0.00)[asn:12502, ipnet:2001:14f8::/32, country:DE]
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.33
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-ports>,
 <mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports/>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
 <mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 23 Aug 2020 20:14:36 -0000

Hi!

> | A quick fix is to add CFLAGS+=-fcommon to your make.conf, but that is
> | rather a big hammer. It is better to add it to just the ports that show
> | problems due to duplicated symbols. And ideally, those duplicated
> | symbols should be patched out of the ports.
> 
> So:  apparently *a* way around this is to change the Makefile (to
> include 'CFLAGS+=-fcommon') -- but I don't know if a "better" approach
> is feasible: we are dealing with some rather old (or, perhaps,
> "well-established") code, here.
> 
> Advice/suggestions?

It's just as it says:

Commit the fix with -fcommon, and then fix the code, if you can 8-}

-- 
pi@opsec.eu            +49 171 3101372                    Now what ?