From owner-freebsd-current@FreeBSD.ORG Thu Jul 26 20:36:02 2007 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3F38816A419 for ; Thu, 26 Jul 2007 20:36:02 +0000 (UTC) (envelope-from mike@sentex.net) Received: from smarthost1.sentex.ca (smarthost1.sentex.ca [64.7.153.18]) by mx1.freebsd.org (Postfix) with ESMTP id 02B7213C4D3 for ; Thu, 26 Jul 2007 20:36:01 +0000 (UTC) (envelope-from mike@sentex.net) Received: from lava.sentex.ca (pyroxene.sentex.ca [199.212.134.18]) by smarthost1.sentex.ca (8.13.8/8.13.8) with ESMTP id l6QKZvfe010512; Thu, 26 Jul 2007 16:35:57 -0400 (EDT) (envelope-from mike@sentex.net) Received: from mdt-xp.sentex.net (simeon.sentex.ca [192.168.43.27]) by lava.sentex.ca (8.13.8/8.13.3) with ESMTP id l6QKZtnd067391 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 26 Jul 2007 16:35:56 -0400 (EDT) (envelope-from mike@sentex.net) Message-Id: <200707262035.l6QKZtnd067391@lava.sentex.ca> X-Mailer: QUALCOMM Windows Eudora Version 7.1.0.9 Date: Thu, 26 Jul 2007 16:35:51 -0400 To: Dag-Erling =?iso-8859-1?Q?Sm=C3=B8rgrav?= From: Mike Tancsa In-Reply-To: <86ir86hqhc.fsf@ds4.des.no> References: <46337B06.9080102@ybb.ne.jp> <46338C0F.9000608@ybb.ne.jp> <4633932A.8080602@ybb.ne.jp> <86tzuxni1b.fsf@dwp.des.no> <200707061723.l66HNYSe037055@lava.sentex.ca> <86ir86hqhc.fsf@ds4.des.no> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1"; format=flowed Content-Transfer-Encoding: quoted-printable Cc: Takeharu KATO , freebsd-current@freebsd.org Subject: Re: ichwd for ICH8 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Jul 2007 20:36:02 -0000 At 04:14 PM 7/26/2007, Dag-Erling Sm=C3=B8rgrav wrote: >Mike Tancsa writes: > > Any chance to commit this to the tree ? It works really well with a > > number of newer chipsets out there, that the old ichwd does not work > > with. > >Turns out my new ICH8 motherboard has the WDT disabled in hardware, so I >can't test this myself. Please test the following patch: > > http://people.freebsd.org/~des/software/ichwd-20070726.diff Thanks! On RELENG_6, 0[image62]# patch < ichwd-20070726.diff Hmm... Looks like a unified diff to me... The text leading up to this was: -------------------------- |Index: sys/dev/ichwd/ichwd.c |=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D |RCS file: /home/ncvs/src/sys/dev/ichwd/ichwd.c,v |retrieving revision 1.9 |diff -u -r1.9 ichwd.c |--- sys/dev/ichwd/ichwd.c 27 Mar 2007 21:03:36 -0000 1.9 |+++ sys/dev/ichwd/ichwd.c 26 Jul 2007 20:03:46 -0000 -------------------------- Patching file sys/dev/ichwd/ichwd.c using Plan A... Hunk #1 succeeded at 51. Hunk #2 succeeded at 73. Hunk #3 succeeded at 104. Hunk #4 succeeded at 115. Hunk #5 succeeded at 154. Hunk #6 succeeded at 165. Hunk #7 succeeded at 259. Hunk #8 succeeded at 289. Hunk #9 succeeded at 332. Hunk #10 succeeded at 376. Hunk #11 succeeded at 421. Hunk #12 succeeded at 432. Hunk #13 succeeded at 455. Hmm... The next patch looks like a unified diff to me... The text leading up to this was: -------------------------- |Index: sys/dev/ichwd/ichwd.h |=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D |RCS file: /home/ncvs/src/sys/dev/ichwd/ichwd.h,v |retrieving revision 1.3 |diff -u -r1.3 ichwd.h |--- sys/dev/ichwd/ichwd.h 17 Feb 2006 18:46:18 -0000 1.3 |+++ sys/dev/ichwd/ichwd.h 26 Jul 2007 16:20:22 -0000 -------------------------- Patching file sys/dev/ichwd/ichwd.h using Plan A... Hunk #1 succeeded at 32. Hunk #2 succeeded at 55. Hunk #3 succeeded at 76. Hunk #4 succeeded at 99. Hunk #5 succeeded at 130. done 0[image62]# But I get 0[image62]# make Warning: Object directory not changed from original= /usr/src/sys/modules/ichwd cc -O2 -pipe -fno-strict-aliasing -Werror=20 -D_KERNEL -DKLD_MODULE -nostdinc -I- -I. -I@=20 -I@/contrib/altq -I@/../include=20 -finline-limit=3D8000=20 -fno-common -mno-align-long-strings=20 -mpreferred-stack-boundary=3D2 -mno-mmx -mno-3dnow=20 -mno-sse -mno-sse2 -ffreestanding -Wall=20 -Wredundant-decls -Wnested-externs=20 -Wstrict-prototypes -Wmissing-prototypes=20 -Wpointer-arith -Winline=20 -Wcast-qual -fformat-extensions -std=3Dc99 -c=20 /usr/src/sys/modules/ichwd/../../dev/ichwd/ichwd.c /usr/src/sys/modules/ichwd/../../dev/ichwd/ichwd.c:=20 In function `ichwd_clear_noreboot': /usr/src/sys/modules/ichwd/../../dev/ichwd/ichwd.c:228:=20 warning: implicit declaration of function `device__printf' /usr/src/sys/modules/ichwd/../../dev/ichwd/ichwd.c:228:=20 warning: nested extern declaration of `device__printf' *** Error code 1 Stop in /usr/src/sys/modules/ichwd. 1[image62]# If I change device__printf to device_printf it=20 compiles and I can load it, but it doesnt work 0[image62]# kldload ./ichwd.ko 0[image62]# dmesg | tail -10 da0 at twa0 bus 0 target 0 lun 0 da0: Fixed Direct Access SCSI-5 device da0: 100.000MB/s transfers da0: 76283MB (156227584 512 byte sectors: 255H 63S/T 9724C) Trying to mount root from ufs:/dev/ad4s1a ichwd module loaded ichwd0: on isa0 ichwd0: unable to reserve GCS registers device_attach: ichwd0 attach returned 6 ppc0: parallel port not found. 0[image62]# 0[image62]# watchdogd -t 20 70[image62]# ps -aux | grep dog root 1731 0.0 0.0 1632 1032 p0 S+ 4:21PM 0:00.00 grep dog 0[image62]# Same error on current ichwd module loaded ichwd0: on isa0 ichwd0: ICH WDT present but disabled in BIOS or hardware device_attach: ichwd0 attach returned 6 ppc0: parallel port not found. leopard3# uname -a FreeBSD leopard3.netperf.freebsd.org 7.0-CURRENT=20 FreeBSD 7.0-CURRENT #20: Mon Jul 23 11:58:00 EDT=20 2007=20 rwatson@zoo.freebsd.org:/zoo/usr.obj/rwatson/current/src/sys/GENERIC i386 leopard3# Using the patch as is in http://lists.freebsd.org/pipermail/freebsd-bugs/2007-April/023828.html 0[image62]# dmesg | tail -10 ichwd module loaded ichwd0: on isa0 ichwd0: unable to reserve GCS registers device_attach: ichwd0 attach returned 6 ppc0: parallel port not found. ichwd module unloaded ichwd module loaded ichwd0: at port 0x430-0x437,0x460-0x469 on isa0 ichwd0: Intel ICH7 watchdog timer (TCO version 2) ppc0: parallel port not found. 0[image62]# watchdogd -t 20 0[image62]# killall -9 watchdogd 0[image62]# 0[image62]# pwd /usr/src/sys/modules/ichwd 0[image62]# The box reboots in ~ 20 seconds On CURRENT leopard3# dmesg | tail -10 ichwd module loaded ichwd0: on isa0 ichwd0: ICH WDT present but disabled in BIOS or hardware device_attach: ichwd0 attach returned 6 ppc0: parallel port not found. ichwd module unloaded ichwd module loaded ichwd0: at port 0x1080-0x1087,0x1088-0x1091 on= isa0 ichwd0: Intel ICH7 watchdog timer (TCO version 2) ppc0: parallel port not found. leopard3# watchdogd -t 20 leopard3# But it doesnt kill it. I will have to check that=20 boxes BIOS to see if its disabled, which is likely ---Mike >DES >-- >Dag-Erling Sm=C3=B8rgrav - des@des.no