From owner-svn-src-head@FreeBSD.ORG  Fri Feb  7 18:14:20 2014
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 595E690A;
 Fri,  7 Feb 2014 18:14:20 +0000 (UTC)
Received: from mail-we0-x232.google.com (mail-we0-x232.google.com
 [IPv6:2a00:1450:400c:c03::232])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 783941A0C;
 Fri,  7 Feb 2014 18:14:19 +0000 (UTC)
Received: by mail-we0-f178.google.com with SMTP id q59so2510687wes.23
 for <multiple recipients>; Fri, 07 Feb 2014 10:14:18 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:sender:in-reply-to:references:date:message-id:subject
 :from:to:cc:content-type;
 bh=7gtmIhlOBgOKVPMm6itdVDMsoguSn3jDp3VheKimRJs=;
 b=a78sIdXr9GtHEoShBUk7xUN3ZHLTGTu1yVaZG4iXJGVho6Zr9/DQB+pjzhwjMdZiyF
 7Of9TWHJerDwM9lL/WPbCzgm+zTlLqWYPUAO09nEKQaRawDFVqRWCyInP4wnJcRswBno
 izlxfaPsrnsk3azsFRTaAdbY83df86TWW5QIGFVNs8fhNFb3Bzjygc3Yb4vbbPioGTtd
 jM5ASioVqjrJ/EQeUw0ghPY3xz/VhcQlcYbIdiFKJcR0oJm4vHFq3oq2/qRv9lfxU1ve
 GsajROnYe8IF31n1HzfPI8jMTJsC1goLLspkQzVyF7urJrEh3gCML0H+u4lX4W1m1/f5
 NBHQ==
MIME-Version: 1.0
X-Received: by 10.180.189.139 with SMTP id gi11mr803301wic.53.1391796857934;
 Fri, 07 Feb 2014 10:14:17 -0800 (PST)
Sender: asomers@gmail.com
Received: by 10.194.168.197 with HTTP; Fri, 7 Feb 2014 10:14:17 -0800 (PST)
In-Reply-To: <201402071810.s17IAZtx043815@svn.freebsd.org>
References: <201402071810.s17IAZtx043815@svn.freebsd.org>
Date: Fri, 7 Feb 2014 11:14:17 -0700
X-Google-Sender-Auth: 0rGxZJUDjMkyiOgLTxBRqx3JgI0
Message-ID: <CAOtMX2hcxk0Ff5YBVBHc-qS5jwVseipwJig1GJCyYijwroFS0A@mail.gmail.com>
Subject: Re: svn commit: r261604 - head/contrib/libc++/include
From: Alan Somers <asomers@freebsd.org>
To: Eitan Adler <eadler@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 07 Feb 2014 18:14:20 -0000

On Fri, Feb 7, 2014 at 11:10 AM, Eitan Adler <eadler@freebsd.org> wrote:
> Author: eadler
> Date: Fri Feb  7 18:10:34 2014
> New Revision: 261604
> URL: http://svnweb.freebsd.org/changeset/base/261604
>
> Log:
>   HEAD is not buildable for the past day.  Commit a 'quick fix' in order to permit
>   buildworld to complete.
>
>   Reviewed by:  theraven
>
> Modified:
>   head/contrib/libc++/include/locale

Are you sure that this will work on all architectures?  It implicitly
assumes that ptrdiff_t is the same as long.  IMHO, it's better to cast
the left side of the comparison to size_t, because it will always be
nonnegative as long as __a_end is greater than or equal to __a.  They
certainly sound like it, based on the names.

-Alan