Date: Fri, 24 Jul 2015 16:04:31 -0400 From: Allan Jude <allanjude@freebsd.org> To: Pedro Giffuni <pfg@FreeBSD.org>, Antoine Brodin <antoine@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r285803 - head/bin/ls Message-ID: <55B29A4F.1070808@freebsd.org> In-Reply-To: <55B294DB.9020000@FreeBSD.org> References: <201507221958.t6MJwLEk015409@repo.freebsd.org> <CAALwa8=yxd6%2BTmNgrFNwJP_ZAjHWLhdEqumfsPgf%2BPfWCn5pFw@mail.gmail.com> <55B28D93.5090003@freebsd.org> <55B294DB.9020000@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2015-07-24 15:41, Pedro Giffuni wrote: > > > On 07/24/15 14:10, Allan Jude wrote: >> ... > >> >> The r285734 change didn't explicitly cast some references to uid_t, >> resulting in a segfault on i386. Clang generated a warning about this >> immediately while I was debugging when I duplicated the xo_emit >> command as a printf. >> >> Can we teach our clang that xo_emit is printf, and so the same >> formatting type matching should be checked? That would be very helpful. >> > > Perhaps something like this? (untested) > > Pedro. > > Yes, jhb@ pointed me in the same direction, and I have already submitted it upstream. It seems they already had it on some things, just not the most useful case. https://github.com/Juniper/libxo/pull/45 -- Allan Jude
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?55B29A4F.1070808>