From owner-freebsd-ports@FreeBSD.ORG Tue Apr 14 11:44:02 2015 Return-Path: Delivered-To: ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id A49C8FCB for ; Tue, 14 Apr 2015 11:44:02 +0000 (UTC) Received: from mail.gemius.pl (mail.gemius.pl [85.232.225.147]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 2BF402FF for ; Tue, 14 Apr 2015 11:44:01 +0000 (UTC) Received: from mail.gemius.pl ([85.232.225.147] helo=acid.gem.lan) by mail.gemius.pl with esmtpa (Exim 4.80.1 (FreeBSD)) (envelope-from ) id 1YhzFv-000MlP-R6; Tue, 14 Apr 2015 13:43:51 +0200 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: MooseFS Ports for versions 2.0 and 3.0 From: Jakub Kruszona-Zawadzki In-Reply-To: Date: Tue, 14 Apr 2015 13:43:50 +0200 Cc: =?iso-8859-1?Q?Fernando_Apestegu=EDa?= , FreeBSD Ports , freebsd@moosefs.com Message-Id: <33D11311-008D-43F5-A341-316CD4D831EA@gemius.com> References: <2694094.4JmStLgM3m@hp> <3504531.pypRB0Rknn@hp> To: Ben Woods X-Mailer: Apple Mail (2.1878.6) X-Authorized: Jakub Kruszona-Zawadzki Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Apr 2015 11:44:02 -0000 (...) > 3. It's nice for ports for share parts of their configuration, but I = don't think it should be called "bsd.port.moosefs.mk" (this implies it = is part of the port build scripts). A good example of what you could do = is devel/libtool. It has a Makefile which includes Makefile.common. The = devel/libltdl port also includes = "${.CURDIR}/../libtool/Makefile.common". The name was used by original port creator. I've change it to = Makefile.common.=20 >=20 > 4. @dirrm is now deprecated in pkg-plist. Suggest it is probably = easier to build this with "make install && make makeplist > pkg-plist". = Note that you should check the plist looks correct, and also delete the = top warning line from the generated file. Yes. I've changed @dirrm[try] to @dir or removed them. I've also added = '@owner mfs' and '@group mfs' and compared each list with the result of = "make makeplist". >=20 > 5. The pkg-descr file should be updated to include a better = description of the package, and link to the website. Yes. I've made much better descriptions. >=20 > 6. Before submitting a port, check that it passes the normal checks by = installing the ports-mgmt/portlint program, and running "portlint -AC" = in the port directory. portlint -AC gives something like this: [root@fbsdmule /usr/ports/sysutils/moosefs-master]# portlint -AC WARN: Makefile: PORTVERSION/DISTVERSION is set externally to this port's = Makefile, but this port is not configured as a slave port. WARN: Makefile: MAINTAINER is set externally to this port's Makefile, = but this port is not configured as a slave port. 0 fatal errors and 2 warnings found. I hope that I can leave it - I've checked other random ports and such = warning are very usual. >=20 > 7. If you have access to a poudriere installation, you should submit = the "poudriere testport" logs showing that this port will build = successfully. Yes we have. We use poudriere to make packages, so all our ports are = always checked by poudriere. > Myself or other ports contributors/committers can help with this if = you do not have access to a poudriere installation, but please make sure = you have at least tested the build on FreeBSD with a "make install". >=20 > Much of this is covered in the porter's handbook. It's a good read if = you haven't already seen it. You can find it here: > https://www.freebsd.org/doc/en/books/porters-handbook/book.html >=20 > Note that if you re-submit patches to each bug report, be sure to tick = the option that it obsolete's the previous patch. Ok. We'll send those ports again. >=20 > Good luck! :) Thanks again for your comments. It was very helpful. --=20 Regards, Jakub Kruszona-Zawadzki - - - - - - - - - - - - - - - - Segmentation fault (core dumped) Phone: +48 602 212 039