From owner-freebsd-current@FreeBSD.ORG Thu Mar 11 02:31:34 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D060516A4CE; Thu, 11 Mar 2004 02:31:34 -0800 (PST) Received: from fe3.cox-internet.com (fe3-cox.cox-internet.com [66.76.2.40]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6A1B643D39; Thu, 11 Mar 2004 02:31:34 -0800 (PST) (envelope-from muntyan@math.tamu.edu) Received: from math.tamu.edu ([66.233.123.200]) by fe3.cox-internet.com ac98e04b23802b25ff26d48c352bda07) with ESMTP id <20040311103133.RZZV24817.fe3@math.tamu.edu>; Thu, 11 Mar 2004 04:31:33 -0600 Message-ID: <40504006.1060407@math.tamu.edu> Date: Thu, 11 Mar 2004 04:31:34 -0600 From: Yevgen Muntyan User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.5) Gecko/20031207 X-Accept-Language: en-us, en MIME-Version: 1.0 To: John Baldwin References: <200402291903.20499.muntyan@tamu.edu> <200403081546.23492.jhb@FreeBSD.org> <200403081743.57194.muntyan@tamu.edu> <200403091325.34299.jhb@FreeBSD.org> In-Reply-To: <200403091325.34299.jhb@FreeBSD.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit cc: freebsd-current@FreeBSD.org Subject: Re: Can't assign irq for integrated wireless NIC X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Mar 2004 10:31:35 -0000 John Baldwin wrote: >Ok, Bill Paul found a bug in my patch. Try this one instead (just adds one >more line): > >Index: if_ndis_pci.c >=================================================================== >RCS file: /usr/cvs/src/sys/dev/if_ndis/if_ndis_pci.c,v >retrieving revision 1.1 >diff -u -r1.1 if_ndis_pci.c >--- if_ndis_pci.c 7 Mar 2004 02:49:06 -0000 1.1 >+++ if_ndis_pci.c 9 Mar 2004 18:24:00 -0000 >@@ -263,6 +263,21 @@ > } > > /* >+ * Allocate an IRQ if we don't already have one. >+ */ >+ if (sc->ndis_irq == NULL) { >+ rid = 0; >+ sc->ndis_irq = bus_alloc_resource(dev, SYS_RES_IRQ, &rid, 0, ~0, 1, >+ RF_SHAREABLE | RF_ACTIVE); >+ if (sc->ndis_irq == NULL) { >+ device_printf(dev, "couldn't route interrupt\n"); >+ error = ENXIO; >+ goto fail; >+ } >+ sc->ndis_rescnt++; >+ } >+ >+ /* > * Allocate the parent bus DMA tag appropriate for PCI. > > It works! Thank you and Bill Paul. Will this be commited? Yevgen