From owner-freebsd-current@FreeBSD.ORG Mon Jun 2 01:22:31 2014 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 2F724BEB for ; Mon, 2 Jun 2014 01:22:31 +0000 (UTC) Received: from smtp.mei.co.jp (smtp.mei.co.jp [133.183.100.20]) by mx1.freebsd.org (Postfix) with ESMTP id C487A2667 for ; Mon, 2 Jun 2014 01:22:30 +0000 (UTC) Received: from mail-gw.jp.panasonic.com ([157.8.1.157]) by smtp.mei.co.jp (8.12.11.20060614/3.7W/kc-maile13) with ESMTP id s521MNJ0004110 for ; Mon, 2 Jun 2014 10:22:23 +0900 (JST) Received: from epochmail.jp.panasonic.com ([157.8.1.130]) by mail.jp.panasonic.com (8.11.6p2/3.7W/kc-maili16) with ESMTP id s521MNM22607 for ; Mon, 2 Jun 2014 10:22:23 +0900 Received: by epochmail.jp.panasonic.com (8.12.11.20060308/3.7W/lomi11) id s521MNEm008897 for freebsd-current@freebsd.org; Mon, 2 Jun 2014 10:22:23 +0900 Received: from localhost by lomi11.jp.panasonic.com (8.12.11.20060308/3.7W) with ESMTP id s521MMX3008875 for ; Mon, 2 Jun 2014 10:22:22 +0900 Date: Mon, 02 Jun 2014 10:22:21 +0900 (JST) Message-Id: <20140602.102221.1420138426517504976.okuno.kohji@jp.panasonic.com> To: freebsd-current@freebsd.org Subject: About the type of physaddr in struct usb_page. From: Kohji Okuno Organization: Panasonic Corporation X-Mailer: Mew version 6.5 on Emacs 24.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Jun 2014 01:22:31 -0000 Hi HPS, I think the type of physaddr in struct usb_page is incorrect. We shuld use bus_addr_t for physaddr. What do you think about this? 60 * The following structure defines physical and non kernel virtual 61 * address of a memory page having size USB_PAGE_SIZE. 62 */ 63 struct usb_page { 64 #if USB_HAVE_BUSDMA 65 bus_size_t physaddr; 66 void *buffer; /* non Kernel Virtual Address */ 67 #endif 68 }; Regards, Kohji Okuno