From nobody Wed Sep 17 22:43:49 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cRv2F73SKz68CLM; Wed, 17 Sep 2025 22:43:49 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cRv2F5wF3z3dlk; Wed, 17 Sep 2025 22:43:49 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1758149029; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=/qgZsBQrFKdqeKOlhb1ngNoW551+YJA6xkf1k6jtu5w=; b=bcDUNB0xpZ9qvQkSERp7Yd6YseOc0Qtm5LkHfX55spu3nTu6NVyhRy7WBwGOBWIXjmitL3 lEDPnwn+ArL5kwbd6ozdtxEV19Mlw78voz83R7aCGI4kTWj4bS8/7Mr7/pnytS8jvq3kO+ +bCT8cSLuHafVqeqbmKcFu3lCKH5FKMbkomZAxGN9d7SVz8BywJJZMlOw5s4J2ws7uiw/X Es7AO8guKyxZiztyZfGM0U+pClNGXLALt1LEuVKDTrZzT6DFL2UQ0obJKdxVP4dJfZfjOz VUs6UqrZnro7K2hUB61kEB7nV+IFgOT2WLjYYhMGocG/d9y8SD//NHnviLpeZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1758149029; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=/qgZsBQrFKdqeKOlhb1ngNoW551+YJA6xkf1k6jtu5w=; b=kYE15reHaqMqxp8XOBIImGKfaGhpAhYDMkFTpm3CfSwaKQezj/w19sceKISrxnzs+cHt2z +Z9qdEdeysN+ilyKqhB2scP//Hu6hqoiKk9kYl9rrT85LkUh9WUkKZ/L3hgEBEQkaXM4rU 19D5PelDJR+Y8Cklczh6SV1oGztSbq5+ddQkC8312jmxqZDNvpSE7dkP03rS4J4zzZzLHp JOkphnRFX3og6zoa59VvyyjankzfkSqIF3qAVBAd/Wyqxs6TXvIi5UYOU8jNE1KdbcvEJO BLjjieis4HWDbC9i/fr4a2PrDwG7/jpGJcVG23uzQgqZihcRgksdxZUgcj4P5A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1758149029; a=rsa-sha256; cv=none; b=IPeqSQDbVkK+Ok8XGUoWkyDd/xXCTluRzhru3FDVxhI1zDwzzkl0PLtBu53XstIqMWwicd Ofi1kzLplArntiHaKtHO6hDjI0z4nF9wTydr0Z0Gi80dhMAWslFp8eT8w0uCI+ekSh5SpN gF4uNdDvPMpIzru6HeiPMa15DNitXaJL0dn6MJS+tndQVQ99EXdSbHRIHqzU7lwVH1O2bi 5/eDd2P0tz4FqnmeqstfVvmAVZPcMpKfNmAvCFEygmdP1Z5+5XL9DhuRTjAfx5oi2yYhOC UwowCoETL24EDD/BMl2o8xNBW1PKWDIGX9HsGArMibL941Eg4Z+o0AIo9Skuiw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cRv2F5G4Vzm1K; Wed, 17 Sep 2025 22:43:49 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 58HMhn1V073227; Wed, 17 Sep 2025 22:43:49 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 58HMhnnD073224; Wed, 17 Sep 2025 22:43:49 GMT (envelope-from git) Date: Wed, 17 Sep 2025 22:43:49 GMT Message-Id: <202509172243.58HMhnnD073224@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mateusz Guzik Subject: git: ea1652bc01c4 - main - vfs: remove a stale comment about unlock + unref relationship in vput List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: mjg X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: ea1652bc01c4093eb4a8c6971c69a410883df189 Auto-Submitted: auto-generated The branch main has been updated by mjg: URL: https://cgit.FreeBSD.org/src/commit/?id=ea1652bc01c4093eb4a8c6971c69a410883df189 commit ea1652bc01c4093eb4a8c6971c69a410883df189 Author: Mateusz Guzik AuthorDate: 2025-09-17 22:40:24 +0000 Commit: Mateusz Guzik CommitDate: 2025-09-17 22:43:34 +0000 vfs: remove a stale comment about unlock + unref relationship in vput It does not hold since introduction of vnode state tracking, which validates unlock only happens after the target vnode is sorted out (fully constructed or aborted). See 829f0bcb5fe24bb5 ("vfs: add the concept of vnode state transitions"). --- sys/kern/vfs_subr.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/sys/kern/vfs_subr.c b/sys/kern/vfs_subr.c index f86bda2aa6f0..fe299ecc9c56 100644 --- a/sys/kern/vfs_subr.c +++ b/sys/kern/vfs_subr.c @@ -3567,11 +3567,6 @@ enum vput_op { VRELE, VPUT, VUNREF }; * exclusive lock on the vnode, while it is legal to call here with only a * shared lock (or no locks). If locking the vnode in an expected manner fails, * inactive processing gets deferred to the syncer. - * - * XXX Some filesystems pass in an exclusively locked vnode and strongly depend - * on the lock being held all the way until VOP_INACTIVE. This in particular - * happens with UFS which adds half-constructed vnodes to the hash, where they - * can be found by other code. */ static void vput_final(struct vnode *vp, enum vput_op func)