From owner-freebsd-bugs@FreeBSD.ORG  Fri Jun 22 22:20:04 2007
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
X-Original-To: freebsd-bugs@hub.freebsd.org
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id CCAD316A46B
	for <freebsd-bugs@hub.freebsd.org>;
	Fri, 22 Jun 2007 22:20:04 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [69.147.83.40])
	by mx1.freebsd.org (Postfix) with ESMTP id B187E13C44B
	for <freebsd-bugs@hub.freebsd.org>;
	Fri, 22 Jun 2007 22:20:04 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id l5MMK4HD084143
	for <freebsd-bugs@freefall.freebsd.org>; Fri, 22 Jun 2007 22:20:04 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.13.4/8.13.4/Submit) id l5MMK47F084142;
	Fri, 22 Jun 2007 22:20:04 GMT (envelope-from gnats)
Resent-Date: Fri, 22 Jun 2007 22:20:04 GMT
Resent-Message-Id: <200706222220.l5MMK47F084142@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org,
	Aaron Needles <aneedles@ieee.org>
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 4F78416A400
	for <freebsd-gnats-submit@FreeBSD.org>;
	Fri, 22 Jun 2007 22:18:54 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (www.freebsd.org [69.147.83.33])
	by mx1.freebsd.org (Postfix) with ESMTP id 2B2B113C448
	for <freebsd-gnats-submit@FreeBSD.org>;
	Fri, 22 Jun 2007 22:18:54 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from www.freebsd.org (localhost [127.0.0.1])
	by www.freebsd.org (8.13.1/8.13.1) with ESMTP id l5MMIsoL089840
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 22 Jun 2007 22:18:54 GMT
	(envelope-from nobody@www.freebsd.org)
Received: (from nobody@localhost)
	by www.freebsd.org (8.13.1/8.13.1/Submit) id l5MMIr23089838;
	Fri, 22 Jun 2007 22:18:53 GMT (envelope-from nobody)
Message-Id: <200706222218.l5MMIr23089838@www.freebsd.org>
Date: Fri, 22 Jun 2007 22:18:53 GMT
From: Aaron Needles <aneedles@ieee.org>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-3.0
Cc: 
Subject: misc/113958: bstp_update_state() routine in net/bridgestp.c misuse
	"bp" in loop
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 22 Jun 2007 22:20:04 -0000


>Number:         113958
>Category:       misc
>Synopsis:       bstp_update_state() routine in net/bridgestp.c misuse "bp" in loop
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Jun 22 22:20:04 GMT 2007
>Closed-Date:
>Last-Modified:
>Originator:     Aaron Needles
>Release:        FreeBSD 6-STABLE (RELENG_6)
>Organization:
Schilling Robotics, LLC
>Environment:
N/A
>Description:
Source code issue.  Affect unknown.

Find bstp_update_state() routine in net/bridgestp.c

The following items...
bp->bp_role
bp->bp_synced

Should be changed to use bp2...
bp2->bp_role
bp2->bp_synced

.. otherwise, the code makes no sense.
>How-To-Repeat:

>Fix:


>Release-Note:
>Audit-Trail:
>Unformatted: