From owner-svn-src-head@FreeBSD.ORG Thu Nov 7 19:58:05 2013 Return-Path: Delivered-To: svn-src-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 5C2F1AB9; Thu, 7 Nov 2013 19:58:05 +0000 (UTC) (envelope-from ian@FreeBSD.org) Received: from mho-01-ewr.mailhop.org (mho-03-ewr.mailhop.org [204.13.248.66]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 1ED362989; Thu, 7 Nov 2013 19:58:04 +0000 (UTC) Received: from c-24-8-230-52.hsd1.co.comcast.net ([24.8.230.52] helo=damnhippie.dyndns.org) by mho-01-ewr.mailhop.org with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.72) (envelope-from ) id 1VeViN-000Ni4-PA; Thu, 07 Nov 2013 19:58:03 +0000 Received: from [172.22.42.240] (revolution.hippie.lan [172.22.42.240]) by damnhippie.dyndns.org (8.14.3/8.14.3) with ESMTP id rA7Jw1k8065206; Thu, 7 Nov 2013 12:58:01 -0700 (MST) (envelope-from ian@FreeBSD.org) X-Mail-Handler: Dyn Standard SMTP by Dyn X-Originating-IP: 24.8.230.52 X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/sendlabs/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX18DoOmhL0K2dX8vc/v0hJiE Subject: Re: svn commit: r257770 - head/lib/msun/src From: Ian Lepore To: Steve Kargl In-Reply-To: <201311062344.rA6Niqkf001246@svn.freebsd.org> References: <201311062344.rA6Niqkf001246@svn.freebsd.org> Content-Type: text/plain; charset="us-ascii" Date: Thu, 07 Nov 2013 12:58:01 -0700 Message-ID: <1383854281.31172.214.camel@revolution.hippie.lan> Mime-Version: 1.0 X-Mailer: Evolution 2.32.1 FreeBSD GNOME Team Port Content-Transfer-Encoding: 7bit Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Nov 2013 19:58:05 -0000 On Wed, 2013-11-06 at 23:44 +0000, Steve Kargl wrote: > Author: kargl > Date: Wed Nov 6 23:44:52 2013 > New Revision: 257770 > URL: http://svnweb.freebsd.org/changeset/base/257770 > > Log: > * Use "math.h" instead of . > * Use bit twiddling. This requires inclusion of math_private.h > and inclusion of float.h in s_roundl.c. Raise invalid exception. > * Use literal integer constants where possible. Let the compiler > do the appropriate conversion. > * In s_roundf.c, use an F suffix on float constants instead of > promoting float to double and then converting the result back > to float. In s_roundl.c, use an L suffix. > * In s_roundl.c, use the ENTERI and RETURNI macros. This requires > the inclusion of fpmath.h and on __i386__ class hardware ieeefp.h. > > Reviewed by: bde > > Modified: > head/lib/msun/src/s_round.c > head/lib/msun/src/s_roundf.c > head/lib/msun/src/s_roundl.c > [snip] FYI, this seems to be causing build failures on non-x86 platforms. For example... ===> lib/msun (obj,depend,all,install) cc -fpic -DPIC -O -pipe -I/local/build/staging/freebsd/bb/src/lib/msun/src -I/local/build/staging/freebsd/bb/src/lib/msun/../libc/include -I/local/build/staging/freebsd/bb/src/lib/msun/../libc/arm -std=gnu99 -Qunused-arguments -Wsystem-headers -Werror -Wno-pointer-sign -Wno-empty-body -Wno-string-plus-int -Wno-tautological-compare -Wno-unused-value -Wno-parentheses-equality -Wno-unused-function -Wno-conversion -Wno-switch -Wno-switch-enum -Wno-knr-promoted-parameter -Wno-parentheses -c /local/build/staging/freebsd/bb/src/lib/msun/src/s_roundl.c -o s_roundl.So /local/build/staging/freebsd/bb/src/lib/msun/src/s_roundl.c:45:2: error: no member named 'xbits' in 'union IEEEl2bits'; did you mean 'bits'? GET_LDBL_EXPSIGN(hx, x); ^ /local/build/staging/freebsd/bb/src/lib/msun/src/math_private.h:224:14: note: expanded from macro 'GET_LDBL_EXPSIGN' (i) = ge_u.xbits.expsign; \ ^ /local/build/staging/freebsd/bb/src/lib/msun/../libc/arm/_fpmath.h:54:4: note: 'bits' declared here } bits; ^ /local/build/staging/freebsd/bb/src/lib/msun/src/s_roundl.c:45:2: error: no member named 'expsign' in 'struct IEEEl2bits::' GET_LDBL_EXPSIGN(hx, x); ^~~~~~~~~~~~~~~~~~~~~~~ /local/build/staging/freebsd/bb/src/lib/msun/src/math_private.h:224:20: note: expanded from macro 'GET_LDBL_EXPSIGN' (i) = ge_u.xbits.expsign; \ ~~~~~~~~~~ ^ 2 errors generated. *** [s_roundl.So] Error code 1 bmake[3]: stopped in /local/build/staging/freebsd/bb/src/lib/msun cc -O -pipe -I/local/build/staging/freebsd/bb/src/lib/msun/src -I/local/build/staging/freebsd/bb/src/lib/msun/../libc/include -I/local/build/staging/freebsd/bb/src/lib/msun/../libc/arm -std=gnu99 -Qunused-arguments -Wsystem-headers -Werror -Wno-pointer-sign -Wno-empty-body -Wno-string-plus-int -Wno-tautological-compare -Wno-unused-value -Wno-parentheses-equality -Wno-unused-function -Wno-conversion -Wno-switch -Wno-switch-enum -Wno-knr-promoted-parameter -Wno-parentheses -c /local/build/staging/freebsd/bb/src/lib/msun/src/s_roundl.c -o s_roundl.o /local/build/staging/freebsd/bb/src/lib/msun/src/s_roundl.c:45:2: error: no member named 'xbits' in 'union IEEEl2bits'; did you mean 'bits'? GET_LDBL_EXPSIGN(hx, x); ^ /local/build/staging/freebsd/bb/src/lib/msun/src/math_private.h:224:14: note: expanded from macro 'GET_LDBL_EXPSIGN' (i) = ge_u.xbits.expsign; \ ^ /local/build/staging/freebsd/bb/src/lib/msun/../libc/arm/_fpmath.h:54:4: note: 'bits' declared here } bits; ^ /local/build/staging/freebsd/bb/src/lib/msun/src/s_roundl.c:45:2: error: no member named 'expsign' in 'struct IEEEl2bits::' GET_LDBL_EXPSIGN(hx, x); ^~~~~~~~~~~~~~~~~~~~~~~ /local/build/staging/freebsd/bb/src/lib/msun/src/math_private.h:224:20: note: expanded from macro 'GET_LDBL_EXPSIGN' (i) = ge_u.xbits.expsign; \ ~~~~~~~~~~ ^ 2 errors generated. *** [s_roundl.o] Error code 1 bmake[3]: stopped in /local/build/staging/freebsd/bb/src/lib/msun -- Ian