From owner-freebsd-arm@FreeBSD.ORG  Wed May 11 22:35:55 2011
Return-Path: <owner-freebsd-arm@FreeBSD.ORG>
Delivered-To: freebsd-arm@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id EEC8D106566B
	for <freebsd-arm@freebsd.org>; Wed, 11 May 2011 22:35:55 +0000 (UTC)
	(envelope-from damjan.marion@gmail.com)
Received: from mail-wy0-f182.google.com (mail-wy0-f182.google.com
	[74.125.82.182])
	by mx1.freebsd.org (Postfix) with ESMTP id 760E58FC0C
	for <freebsd-arm@freebsd.org>; Wed, 11 May 2011 22:35:55 +0000 (UTC)
Received: by wyf23 with SMTP id 23so1014958wyf.13
	for <freebsd-arm@freebsd.org>; Wed, 11 May 2011 15:35:54 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=domainkey-signature:content-type:mime-version:subject:from
	:in-reply-to:date:content-transfer-encoding:message-id:references:to
	:x-mailer; bh=EtvQKasi/q8zB9KZzdNk3w9zDqFMUFrbR/YKD9/TbaQ=;
	b=KF2QX1IXWDy1gSIidtEg4+pQuqJxte906Rt238xtV1O9c7t1qxTeUp5kV8/iOfm2iJ
	mN4ffe43A/7bnzLixzuzRpCUvRs7yb2KsW7jHHp3n2z9lCOXwGmuctMPjixO1YKJvYpp
	UN3yNzC2H2qe8NnIIG9bUgpv6+vYnNl9HbNgY=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
	h=content-type:mime-version:subject:from:in-reply-to:date
	:content-transfer-encoding:message-id:references:to:x-mailer;
	b=go6+nK8uoqoMSbLQ6f+mUXUv1N/b01LQg9x2ngELxzD+oEtYHX/oYdC42dTOxZrSex
	Tjsd2ID6popRTrxb7bRaABz+rdJbgxSDHiHlnG9mPulqLfg82GDqwWWGMYT3BuJbsW2J
	uwqvmzP8VfD3a86mw4Q6UZyjvjgyLL9c8gu7g=
Received: by 10.227.10.67 with SMTP id o3mr10158772wbo.26.1305153354238;
	Wed, 11 May 2011 15:35:54 -0700 (PDT)
Received: from [192.168.123.4] (cpe-109-60-66-194.zg3.cable.xnet.hr
	[109.60.66.194])
	by mx.google.com with ESMTPS id y29sm386917wbd.4.2011.05.11.15.35.52
	(version=TLSv1/SSLv3 cipher=OTHER);
	Wed, 11 May 2011 15:35:52 -0700 (PDT)
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Apple Message framework v1084)
From: Damjan Marion <damjan.marion@gmail.com>
In-Reply-To: <B823839E-A0B2-4994-BDD8-6AC8747DCCEC@gmail.com>
Date: Thu, 12 May 2011 00:35:50 +0200
Content-Transfer-Encoding: quoted-printable
Message-Id: <2A67CDC2-37BA-4ABE-9E7E-8C151E7E9887@gmail.com>
References: <B823839E-A0B2-4994-BDD8-6AC8747DCCEC@gmail.com>
To: freebsd-arm@freebsd.org
X-Mailer: Apple Mail (2.1084)
Subject: Re: Few issues with Marvell code
X-BeenThere: freebsd-arm@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting FreeBSD to the StrongARM Processor <freebsd-arm.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arm>,
	<mailto:freebsd-arm-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arm>
List-Post: <mailto:freebsd-arm@freebsd.org>
List-Help: <mailto:freebsd-arm-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arm>,
	<mailto:freebsd-arm-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 11 May 2011 22:35:56 -0000


On May 3, 2011, at 10:42 PM, Damjan Marion wrote:

>=20
> Hi,
>=20
> During my attempt to bring up 88F5181L I found few issues with current =
marvell code:
>=20
> 1. There is a typo in sys/arm/mv/common.c
>=20
> -       { "mvrl,pcie", &decode_win_pcie_setup, NULL },
> +       { "mrvl,pcie", &decode_win_pcie_setup, NULL },
>=20
>=20
> 2. Even if this is fixed, decode_win_pcie_setup will not be executed =
as in FDT file pci tree sits outside of SOC tree
>=20
>=20
> 3. CPU decode windows setup in FDT localbus tree is missing target, =
instead target is hardcoded to 1:
>=20
> 	cpu_win_tbl[t].target =3D 1;=20
>=20
> On other side 1st column looks like a sequence. Is this 1st column =
needed?=20
> Can we extend this definition to also have target defined?
>=20
> I.e. In case of 88F5181L I need to add following window, and it will =
be more convenient to do that in FDT file.
>=20
> 	cpu_win_tbl[++t].target =3D 0x04;
> 	cpu_win_tbl[t].attr =3D 0x79;
> 	cpu_win_tbl[t].base =3D 0xf0000000;
> 	cpu_win_tbl[t].size =3D 0x01000000;
> 	cpu_win_tbl[t].remap =3D -1;
>=20

I will appreciate if somebody can comment this :)

Thanks,

Damjan=