Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 28 Nov 2012 12:59:11 -0500
From:      Eitan Adler <eadler@freebsd.org>
To:        gahr@freebsd.org
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, Emanuel Haupt <ehaupt@freebsd.org>, ports-committers@freebsd.org
Subject:   Re: svn commit: r307902 - head/graphics/grafx2/files
Message-ID:  <CAF6rxg=S%2BkrT=FOB_ZGRXhr3k5yk1iKXEnhu1JzSqU_ZmRe5ng@mail.gmail.com>
In-Reply-To: <20121128174239.GA64813@gahrfit.gahr.ch>
References:  <201211281129.qASBT6Aw015051@svn.freebsd.org> <CAF6rxgnp0fZkScwc9HwKxPdm2KbT4pKsO%2B79t7bWVMop6JtXfA@mail.gmail.com> <20121128174239.GA64813@gahrfit.gahr.ch>

next in thread | previous in thread | raw e-mail | index | archive | help
On 28 November 2012 12:42, Pietro Cerutti <gahr@freebsd.org> wrote:
> On 2012-Nov-28, 12:37, Eitan Adler wrote:
>> On 28 November 2012 06:29, Emanuel Haupt <ehaupt@freebsd.org> wrote:
>> > Author: ehaupt
>> > Date: Wed Nov 28 11:29:06 2012
>> > New Revision: 307902
>> > URL: http://svnweb.freebsd.org/changeset/ports/307902
>> >
>> > Log:
>> >   Add patchfile.
>>
>> What does the patchfile do? Why is it needed? Was upstream contacted?
>>
>> - these should be documented in the log message.
>
> oh come on...
>
> +-#if defined(__AROS__) || defined(__linux__) || defined(__GLIBC__)
> ++#if defined(__AROS__) || defined(__linux__) || defined(__GLIBC__) || defined(__FreeBSD__)
>
> isn't this clear enough?

%svn log -cr307902
------------------------------------------------------------------------
r307902 | ehaupt | 2012-11-28 06:29:06 -0500 (Wed, 28 Nov 2012) | 4 lines

Add patchfile.

Feature safe:   yes

------------------------------------------------------------------------


also the patch file itself only answers parts 1 and 2.

-- 
Eitan Adler
Source, Ports, Doc committer
Bugmeister, Ports Security teams



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAF6rxg=S%2BkrT=FOB_ZGRXhr3k5yk1iKXEnhu1JzSqU_ZmRe5ng>