From owner-freebsd-ports@FreeBSD.ORG Tue Nov 30 15:37:16 2010 Return-Path: Delivered-To: ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E065C1065672 for ; Tue, 30 Nov 2010 15:37:16 +0000 (UTC) (envelope-from r.c.ladan@gmail.com) Received: from mail-ew0-f54.google.com (mail-ew0-f54.google.com [209.85.215.54]) by mx1.freebsd.org (Postfix) with ESMTP id 6BCF78FC14 for ; Tue, 30 Nov 2010 15:37:16 +0000 (UTC) Received: by ewy24 with SMTP id 24so2886575ewy.13 for ; Tue, 30 Nov 2010 07:37:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:cc:subject:references:in-reply-to :x-enigmail-version:content-type:content-transfer-encoding; bh=lSsapuuaniQlbG5WRTt0q/IDQozYG+NpmnQ8t37Fg/0=; b=pjALul0ugvpss55oxKqpXaHEYDRBdS6XpjscT8nWzaUH4rYlHduh2idqbx7Do2EKXf uk7RJPCI8LdDP4wt+zB4u1lMldnFG3VHd3ZIIIEGVzkts8SbCq/KavBTHs5E0572unGG mY/sFV4QWCCV5Qc+AKbrG80/QyDqjBytFwPtA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:x-enigmail-version:content-type :content-transfer-encoding; b=Qpk16h8dSvZXbbxEVAEmBPwx7OfFp9AeCOEyOFMF15NOd6M+W3lq7+7bEQ2vtQr+9Z +IhVw1pXVsczfTd5vWrpEY1fwEIrhf9H0dh8Bm+vkeohdGXX04i0Lh/mff5Hrf6uGqBc lDQXKv1zJKfE/2WZnN4B9i0XGsflPifc9JMFs= Received: by 10.213.17.72 with SMTP id r8mr2080126eba.58.1291131434979; Tue, 30 Nov 2010 07:37:14 -0800 (PST) Received: from [192.168.1.64] (ip4da3ae31.direct-adsl.nl [77.163.174.49]) by mx.google.com with ESMTPS id v56sm6465146eeh.14.2010.11.30.07.37.04 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 30 Nov 2010 07:37:07 -0800 (PST) Message-ID: <4CF51A1F.7030803@gmail.com> Date: Tue, 30 Nov 2010 16:37:03 +0100 From: Rene Ladan User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; nl-NL; rv:1.9.2.12) Gecko/20101029 Thunderbird/3.1.6 MIME-Version: 1.0 To: Mark Linimon References: <20101130041323.GA17404@lonesome.com> In-Reply-To: <20101130041323.GA17404@lonesome.com> X-Enigmail-Version: 1.1.2 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: ports@FreeBSD.org Subject: Re: CFR: patch to cleanup usage of SRC_BASE in various ports X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Nov 2010 15:37:17 -0000 Op 30-11-2010 05:13, Mark Linimon schreef: > I am trying to debug a problem in the package building scripts, and > in the process of debugging it, have found some inconsistencies with > ports that require kernel sources. For installations that keep their > latest sources in /usr/src, this patch should have no effect; however, > for others (such as pointyhat, which has multiple src trees) this should > fix edge conditions with 'make describe'. > > I would appreciate feedback on the following patch: > > http://people.freebsd.org/~linimon/patches/diff.out.srcbase > Just looking at the patch itself, I've found that ${SRC_BASE} can also be used in line 137, 152, 186, and 205 of the patch. These are ports graphics/kix-kmod, graphics/plasma-kmod, palm/uppc-kmod, and devel-linux_kdump respectively. Rene -- http://www.rene-ladan.nl/ GPG fingerprint = E738 5471 D185 7013 0EE0 4FC8 3C1D 6F83 12E1 84F6 (subkeys.pgp.net)