From owner-svn-src-all@freebsd.org Wed Sep 20 18:25:44 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8537FE1C19E for ; Wed, 20 Sep 2017 18:25:44 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.glebi.us (glebi.us [96.95.210.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "cell.glebi.us", Issuer "cell.glebi.us" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 6AE9076446; Wed, 20 Sep 2017 18:25:43 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.glebi.us (localhost [127.0.0.1]) by cell.glebi.us (8.15.2/8.15.2) with ESMTPS id v8KIPbdJ072775 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Wed, 20 Sep 2017 11:25:37 -0700 (PDT) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.glebi.us (8.15.2/8.15.2/Submit) id v8KIPbVJ072774; Wed, 20 Sep 2017 11:25:37 -0700 (PDT) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.glebi.us: glebius set sender to glebius@FreeBSD.org using -f Date: Wed, 20 Sep 2017 11:25:37 -0700 From: Gleb Smirnoff To: Alexey Dokuchaev Cc: Josh Paetzel , svn-src-all@freebsd.org Subject: Re: svn commit: r323770 - in stable/11/sys: amd64/conf arm64/conf i386/conf powerpc/conf riscv/conf sparc64/conf Message-ID: <20170920182537.GN1055@FreeBSD.org> References: <201709191651.v8JGpp5v048489@repo.freebsd.org> <2B7D21C6-56EE-4ADE-815C-70477C137A82@gmail.com> <1505915939.3128744.1112434136.0864CA5F@webmail.messagingengine.com> <20170920172145.GA80852@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170920172145.GA80852@FreeBSD.org> User-Agent: Mutt/1.8.3 (2017-05-23) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Sep 2017 18:25:44 -0000 On Wed, Sep 20, 2017 at 05:21:45PM +0000, Alexey Dokuchaev wrote: A> On Wed, Sep 20, 2017 at 08:58:59AM -0500, Josh Paetzel wrote: A> > On Wed, Sep 20, 2017, at 02:41 AM, Ngie Cooper (yaneurabeya) wrote: A> > > > On Sep 19, 2017, at 09:51, Josh Paetzel wrote: A> > > > New Revision: 323770 A> > > > URL: https://svnweb.freebsd.org/changeset/base/323770 A> > > > A> > > > Log: A> > > > MFC: 323068 A> > > > A> > > > Allow kldload tcpmd5 A> > > A> > > Wasn't this reverted on ^/head ? A> > A> > Not this one. What was reverted on HEAD was the removal of options A> > IPSEC from GENERIC. A> > A> > The endgoal is options IPSEC and options IPSEC_SUPPORT in GENERIC, which A> > will allow someone running GENERIC to kldload tcpmd5. A> A> I'll shamelessly steal this thread to ask somewhat related question that A> was bothering me since the original botched commit: what is the reason A> behind IPSEC_SUPPORT option? If it does not cost anything, why not just A> optimize it away; if it does imply something more, can you shed some A> light on why is it needed (and/or might not be)? Thanks, The reason is to make loadable ipsec.ko. I actually don't understand why do we still have IPSEC in GENERIC once it is loadable. Doesn't it still have performance impact? -- Gleb Smirnoff