From nobody Mon Sep 19 20:41:19 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MWc6472xyz4cnML; Mon, 19 Sep 2022 20:41:32 +0000 (UTC) (envelope-from bjkfbsd@gmail.com) Received: from mail-vk1-xa2c.google.com (mail-vk1-xa2c.google.com [IPv6:2607:f8b0:4864:20::a2c]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4MWc640Yvzz41Pl; Mon, 19 Sep 2022 20:41:32 +0000 (UTC) (envelope-from bjkfbsd@gmail.com) Received: by mail-vk1-xa2c.google.com with SMTP id s12so325842vkn.11; Mon, 19 Sep 2022 13:41:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=+j+p4sOpOX57JtkFYiIdAiNLzsEONxY2HF0QkEtK35U=; b=DdE4siYhWPoXRGjJKWB5fG8ZJzJamWYoHO6bMrKip0YggOWEe5bNjYbq2bGeLSVtJz nCjN+hAEBzEYbYOuvPM9CQGMvWSyKq+qAobmDriU5schYH6BbK2ta8G50VZHm9o7B424 Pa3SPBJo3gui685cGlN57YAs1eEJST1gzm2W5Nwt8M8/6bkUx0cHdZ5T0suMDZXXS7Lt Oid4/vTmsSm6fw76BGK8OOW8/DyMXFqyeIHVPwbyCUMX5WukCBLdurN6tNmL/VSBaYf4 +ZmoIKdL4/I6QuUx8WuXsfPnW8eZ8lSXDgWJQOELnnjyX/VQXyXL9AlrBHEG6BSbjbMC UDyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=+j+p4sOpOX57JtkFYiIdAiNLzsEONxY2HF0QkEtK35U=; b=wNIM+x5UceDzvJPmcPeooMRKK98BZvc6C4my4xf8MFGzY15ufN7Qk8+GI5SNmt9H7m ILb/QTSEnmYABL/mPaba80yRbtsYi3DGmkiZaEJfG/z5XuzLycCwF38l4TFy2EREPE5j sNQZMvVs6nuP7t49taHEjNcPcctY6/kNuA8zVsJ1/+ophG1FjjtQPgMgmy6zcFc2AGT+ mCA+OynhanTlFUGfSz7xToioLlh6BClnHckVb5+B9SNmLIuoU1/FdRxsQ7E4Fj+NuY+X TPuGHyJ4oGZE6ZrWmQ5v/fNBmarbDPnEuXBEwGadZ1YVQgT8vOxYL2SrUTHT8/b8dI1n wxcQ== X-Gm-Message-State: ACrzQf30kO9T2es8clukfBBn8uzOd2UDygSYbu4Pb+pbf+0syFdR04pp ns04FNVRx7FVzkhOYWL1dgpxargdWV+MG80mz60e1Wm2E2UMyA== X-Google-Smtp-Source: AMsMyM5bgZSr9iB1yBP/Jz39h2egKUOztiLdcWrsiAJwxc0hvDjavzbbTgOEEBif5yuQxt5U2paCRl6snvkZZADzUWI= X-Received: by 2002:a1f:24b:0:b0:3a3:ad4:a3b2 with SMTP id 72-20020a1f024b000000b003a30ad4a3b2mr5829591vkc.13.1663620090401; Mon, 19 Sep 2022 13:41:30 -0700 (PDT) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 References: <202209192009.28JK924f075123@gitrepo.freebsd.org> In-Reply-To: <202209192009.28JK924f075123@gitrepo.freebsd.org> From: Benjamin Kaduk Date: Mon, 19 Sep 2022 13:41:19 -0700 Message-ID: Subject: Re: git: 2c2ef670a79b - main - pseudofs: use the vget_prep/vget_finish idiom To: Mateusz Guzik Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: multipart/alternative; boundary="00000000000087999005e90dbc71" X-Rspamd-Queue-Id: 4MWc640Yvzz41Pl X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20210112 header.b=DdE4siYh; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of bjkfbsd@gmail.com designates 2607:f8b0:4864:20::a2c as permitted sender) smtp.mailfrom=bjkfbsd@gmail.com X-Spamd-Result: default: False [-3.34 / 15.00]; NEURAL_HAM_SHORT(-0.99)[-0.989]; NEURAL_HAM_LONG(-0.98)[-0.980]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; NEURAL_HAM_MEDIUM(-0.37)[-0.368]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20210112]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org,dev-commits-src-main@freebsd.org]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::a2c:from]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FREEMAIL_ENVFROM(0.00)[gmail.com]; RCVD_TLS_LAST(0.00)[]; TO_DN_SOME(0.00)[]; MID_RHS_MATCH_FROMTLD(0.00)[]; FROM_HAS_DN(0.00)[]; ARC_NA(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; RCPT_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FREEMAIL_FROM(0.00)[gmail.com]; RCVD_COUNT_TWO(0.00)[2]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim] X-ThisMailContainsUnwantedMimeParts: N --00000000000087999005e90dbc71 Content-Type: text/plain; charset="UTF-8" On Mon, Sep 19, 2022 at 1:09 PM Mateusz Guzik wrote: > The branch main has been updated by mjg: > > URL: > https://cgit.FreeBSD.org/src/commit/?id=2c2ef670a79b7f8fa84796a04885a3f76c914762 > > commit 2c2ef670a79b7f8fa84796a04885a3f76c914762 > Author: Mateusz Guzik > AuthorDate: 2022-09-19 20:07:10 +0000 > Commit: Mateusz Guzik > CommitDate: 2022-09-19 20:08:40 +0000 > > pseudofs: use the vget_prep/vget_finish idiom > > Picking an arbitrary commit to reply to: could you please add a bit more detail about the "why" to commit messages in the future? Having looked a little bit, it seems that this would be "as part of the broader effort to remove the vnode interlock [from a specific class of operations?]". A pointer to a bigger-picture doc would be great as well. I co-maintain an out-of-tree filesystem and commit messages like this make it really hard for me to get a handle on whether I need to do anything and, if so, where to start looking to find out what to do. An overall project page would be a great reference, or even comment around the implementations that points to a key differential revision that implemented the core behavior. One of the things that's been really nice about developing for the FreeBSD VFS in the past is how easy it is to determine what a filesystem implementation needs to provide, and I'd love to see us continue that tradition. Thanks, Ben --00000000000087999005e90dbc71 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Mon, Sep 19, 2022 at 1:09 PM Mateusz G= uzik <mjg@freebsd.org> wrote:<= br>
The branch main has been updated by mjg:

URL: https://cgit.= FreeBSD.org/src/commit/?id=3D2c2ef670a79b7f8fa84796a04885a3f76c914762
commit 2c2ef670a79b7f8fa84796a04885a3f76c914762
Author:=C2=A0 =C2=A0 =C2=A0Mateusz Guzik <mjg@FreeBSD.org>
AuthorDate: 2022-09-19 20:07:10 +0000
Commit:=C2=A0 =C2=A0 =C2=A0Mateusz Guzik <mjg@FreeBSD.org>
CommitDate: 2022-09-19 20:08:40 +0000

=C2=A0 =C2=A0 pseudofs: use the vget_prep/vget_finish idiom



Picking an arbitrary commit to repl= y to: could you please add a bit more detail about the "why" to c= ommit messages in the future?
Having looked a little bit, it seem= s that this would be "as part of the broader effort to remove the vnod= e interlock [from a specific class of operations?]".=C2=A0 A pointer t= o a bigger-picture doc would be great as well.

I c= o-maintain an out-of-tree filesystem and commit messages like this make it = really hard for me to get a handle on whether I need to do anything and, if= so, where to start looking to find out what to do.=C2=A0 An overall projec= t page would be a great reference, or even comment around the implementatio= ns that points to a key differential revision that implemented the core beh= avior.=C2=A0 One of the things that's been really nice about developing= for the FreeBSD VFS in the past is how easy it is to determine what a file= system implementation needs to provide, and I'd love to see us continue= that tradition.

Thanks,

= Ben=C2=A0
--00000000000087999005e90dbc71--