Date: Mon, 19 Sep 2022 13:41:19 -0700 From: Benjamin Kaduk <bjkfbsd@gmail.com> To: Mateusz Guzik <mjg@freebsd.org> Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 2c2ef670a79b - main - pseudofs: use the vget_prep/vget_finish idiom Message-ID: <CAJ5_RoA4=NqQ-XZ52rJ7J1xJMUg2U=kB%2B7b_x5sLHXFsJGwVSg@mail.gmail.com> In-Reply-To: <202209192009.28JK924f075123@gitrepo.freebsd.org> References: <202209192009.28JK924f075123@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--00000000000087999005e90dbc71 Content-Type: text/plain; charset="UTF-8" On Mon, Sep 19, 2022 at 1:09 PM Mateusz Guzik <mjg@freebsd.org> wrote: > The branch main has been updated by mjg: > > URL: > https://cgit.FreeBSD.org/src/commit/?id=2c2ef670a79b7f8fa84796a04885a3f76c914762 > > commit 2c2ef670a79b7f8fa84796a04885a3f76c914762 > Author: Mateusz Guzik <mjg@FreeBSD.org> > AuthorDate: 2022-09-19 20:07:10 +0000 > Commit: Mateusz Guzik <mjg@FreeBSD.org> > CommitDate: 2022-09-19 20:08:40 +0000 > > pseudofs: use the vget_prep/vget_finish idiom > > Picking an arbitrary commit to reply to: could you please add a bit more detail about the "why" to commit messages in the future? Having looked a little bit, it seems that this would be "as part of the broader effort to remove the vnode interlock [from a specific class of operations?]". A pointer to a bigger-picture doc would be great as well. I co-maintain an out-of-tree filesystem and commit messages like this make it really hard for me to get a handle on whether I need to do anything and, if so, where to start looking to find out what to do. An overall project page would be a great reference, or even comment around the implementations that points to a key differential revision that implemented the core behavior. One of the things that's been really nice about developing for the FreeBSD VFS in the past is how easy it is to determine what a filesystem implementation needs to provide, and I'd love to see us continue that tradition. Thanks, Ben --00000000000087999005e90dbc71 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable <div dir=3D"ltr"><div dir=3D"ltr">On Mon, Sep 19, 2022 at 1:09 PM Mateusz G= uzik <<a href=3D"mailto:mjg@freebsd.org">mjg@freebsd.org</a>> wrote:<= br></div><div class=3D"gmail_quote"><blockquote class=3D"gmail_quote" style= =3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding= -left:1ex">The branch main has been updated by mjg:<br> <br> URL: <a href=3D"https://cgit.FreeBSD.org/src/commit/?id=3D2c2ef670a79b7f8fa= 84796a04885a3f76c914762" rel=3D"noreferrer" target=3D"_blank">https://cgit.= FreeBSD.org/src/commit/?id=3D2c2ef670a79b7f8fa84796a04885a3f76c914762</a><b= r> <br> commit 2c2ef670a79b7f8fa84796a04885a3f76c914762<br> Author:=C2=A0 =C2=A0 =C2=A0Mateusz Guzik <mjg@FreeBSD.org><br> AuthorDate: 2022-09-19 20:07:10 +0000<br> Commit:=C2=A0 =C2=A0 =C2=A0Mateusz Guzik <mjg@FreeBSD.org><br> CommitDate: 2022-09-19 20:08:40 +0000<br> <br> =C2=A0 =C2=A0 pseudofs: use the vget_prep/vget_finish idiom<br><br></blockq= uote><div><br></div><div><br></div><div>Picking an arbitrary commit to repl= y to: could you please add a bit more detail about the "why" to c= ommit messages in the future?</div><div>Having looked a little bit, it seem= s that this would be "as part of the broader effort to remove the vnod= e interlock [from a specific class of operations?]".=C2=A0 A pointer t= o a bigger-picture doc would be great as well.</div><div><br></div><div>I c= o-maintain an out-of-tree filesystem and commit messages like this make it = really hard for me to get a handle on whether I need to do anything and, if= so, where to start looking to find out what to do.=C2=A0 An overall projec= t page would be a great reference, or even comment around the implementatio= ns that points to a key differential revision that implemented the core beh= avior.=C2=A0 One of the things that's been really nice about developing= for the FreeBSD VFS in the past is how easy it is to determine what a file= system implementation needs to provide, and I'd love to see us continue= that tradition.</div><div><br></div><div>Thanks,</div><div><br></div><div>= Ben=C2=A0</div></div></div> --00000000000087999005e90dbc71--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ5_RoA4=NqQ-XZ52rJ7J1xJMUg2U=kB%2B7b_x5sLHXFsJGwVSg>