From owner-freebsd-bugs@FreeBSD.ORG Wed Oct 9 07:00:00 2013 Return-Path: Delivered-To: freebsd-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id E0E33921 for ; Wed, 9 Oct 2013 07:00:00 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id A91F72F57 for ; Wed, 9 Oct 2013 07:00:00 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id r997006x042838 for ; Wed, 9 Oct 2013 07:00:00 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.7/8.14.7/Submit) id r99700CR042837; Wed, 9 Oct 2013 07:00:00 GMT (envelope-from gnats) Resent-Date: Wed, 9 Oct 2013 07:00:00 GMT Resent-Message-Id: <201310090700.r99700CR042837@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Slawa Olhovchenkov Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 8414F606 for ; Wed, 9 Oct 2013 06:54:38 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from oldred.freebsd.org (oldred.freebsd.org [8.8.178.121]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 734E02F26 for ; Wed, 9 Oct 2013 06:54:38 +0000 (UTC) Received: from oldred.freebsd.org ([127.0.1.6]) by oldred.freebsd.org (8.14.5/8.14.7) with ESMTP id r996sbKR010385 for ; Wed, 9 Oct 2013 06:54:37 GMT (envelope-from nobody@oldred.freebsd.org) Received: (from nobody@localhost) by oldred.freebsd.org (8.14.5/8.14.5/Submit) id r996sb7q010383; Wed, 9 Oct 2013 06:54:37 GMT (envelope-from nobody) Message-Id: <201310090654.r996sb7q010383@oldred.freebsd.org> Date: Wed, 9 Oct 2013 06:54:37 GMT From: Slawa Olhovchenkov To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Subject: kern/182851: thread-unsafe handled routing tables X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Oct 2013 07:00:00 -0000 >Number: 182851 >Category: kern >Synopsis: thread-unsafe handled routing tables >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed Oct 09 07:00:00 UTC 2013 >Closed-Date: >Last-Modified: >Originator: Slawa Olhovchenkov >Release: 9.2, 10.0 >Organization: >Environment: >Description: sys/net/radix.c contains /* * Work area -- the following point to 3 buffers of size max_keylen, * allocated in this order in a block of memory malloc'ed by rn_init. * rn_zeros, rn_ones are set in rn_init and used in readonly afterwards. * addmask_key is used in rn_addmask in rw mode and not thread-safe. */ static char *rn_zeros, *rn_ones, *addmask_key; addmask_key used by rn_addmask (called from rn_lookup, rn_addroute and rn_delete). In all cases rn_addmask used in RW mode w/o proper locking. addmask_key is absolutly globaly used -- for IPv4, IPv6 and other at once. As result -- incorrect routing lookup, routing update and so. (for example: kernel: rn_addmask: mask impossibly already in tree) >How-To-Repeat: >Fix: Delete global addmask_key. Use local (on stack in rn_addmask) buffer. >Release-Note: >Audit-Trail: >Unformatted: