From owner-freebsd-net Mon Nov 4 15: 0: 8 2002 Delivered-To: freebsd-net@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9E96237B401 for ; Mon, 4 Nov 2002 15:00:06 -0800 (PST) Received: from InterJet.dellroad.org (adsl-63-194-81-26.dsl.snfc21.pacbell.net [63.194.81.26]) by mx1.FreeBSD.org (Postfix) with ESMTP id C829343E42 for ; Mon, 4 Nov 2002 15:00:05 -0800 (PST) (envelope-from archie@dellroad.org) Received: from arch20m.dellroad.org (arch20m.dellroad.org [10.1.1.20]) by InterJet.dellroad.org (8.9.1a/8.9.1) with ESMTP id OAA29056; Mon, 4 Nov 2002 14:56:38 -0800 (PST) Received: from arch20m.dellroad.org (localhost [127.0.0.1]) by arch20m.dellroad.org (8.12.6/8.12.6) with ESMTP id gA4MuHZE035382; Mon, 4 Nov 2002 14:56:17 -0800 (PST) (envelope-from archie@arch20m.dellroad.org) Received: (from archie@localhost) by arch20m.dellroad.org (8.12.6/8.12.6/Submit) id gA4MuH5k035381; Mon, 4 Nov 2002 14:56:17 -0800 (PST) From: Archie Cobbs Message-Id: <200211042256.gA4MuH5k035381@arch20m.dellroad.org> Subject: Re: MPD and MRU In-Reply-To: <3DA24BE600FF3EA2@mel-rta7.wanadoo.fr> (added by postmaster@wanadoo.fr) "from Vincent Jardin at Nov 4, 2002 10:19:54 pm" To: Vincent Jardin Date: Mon, 4 Nov 2002 14:56:17 -0800 (PST) Cc: net@FreeBSD.org X-Mailer: ELM [version 2.4ME+ PL88 (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII Sender: owner-freebsd-net@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org Vincent Jardin writes: > It looks like it is not possible to configure any MRU values with MPD, due to > LCP_MRU_MARGIN (=20). > > For example, on the PPPoE links, the values between 1473 to 1491 are not > possible. > > ... > link.c: > case SET_MRU: > case SET_MTU: > val = atoi(*av); > name = ((intptr_t)arg == SET_MTU) ? "MTU" : "MRU"; > if (!lnk->phys->type) > Log(LG_ERR, ("[%s] this link has no type set", lnk->name)); > else if (val < LCP_MIN_MRU) > Log(LG_ERR, ("[%s] the min %s is %d", lnk->name, name, LCP_MIN_MRU)); > else if (val + LCP_MRU_MARGIN > lnk->phys->type->mru) > Log(LG_ERR, ("[%s] the max %s on type \"%s\" links is %d", > lnk->name, name, lnk->phys->type->name, > lnk->phys->type->mru - LCP_MRU_MARGIN)); /* XXXXXXXXXX */ > else if ((intptr_t)arg == SET_MTU) > lnk->conf.mtu = val; > else > lnk->conf.mru = val; > break; > ... > > I think that the LCP_MRU_MARGIN tests could be removed or LCP_MRU_MARGIN > could be set to 0. Yes, you're right.. that's a hold-over kludge from before. I'll remove it in the next version. In the meantime, you can just redefine it to zero. -Archie __________________________________________________________________________ Archie Cobbs * Packet Design * http://www.packetdesign.com To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-net" in the body of the message