From owner-freebsd-current@FreeBSD.ORG  Mon Jun  2 07:09:44 2014
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 20449D63
 for <freebsd-current@freebsd.org>; Mon,  2 Jun 2014 07:09:44 +0000 (UTC)
Received: from mail.turbocat.net (mail.turbocat.net
 [IPv6:2a01:4f8:d16:4514::2])
 (using TLSv1.1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id D82FB2154
 for <freebsd-current@freebsd.org>; Mon,  2 Jun 2014 07:09:43 +0000 (UTC)
Received: from laptop015.home.selasky.org
 (cm-176.74.213.204.customer.telag.net [176.74.213.204])
 (using TLSv1 with cipher ECDHE-RSA-AES128-SHA (128/128 bits))
 (No client certificate requested)
 by mail.turbocat.net (Postfix) with ESMTPSA id 4169A1FE026;
 Mon,  2 Jun 2014 09:09:42 +0200 (CEST)
Message-ID: <538C235F.9050105@selasky.org>
Date: Mon, 02 Jun 2014 09:10:23 +0200
From: Hans Petter Selasky <hps@selasky.org>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
 rv:24.0) Gecko/20100101 Thunderbird/24.1.0
MIME-Version: 1.0
To: Kohji Okuno <okuno.kohji@jp.panasonic.com>, 
 freebsd-current@freebsd.org
Subject: Re: About the type of physaddr in struct usb_page.
References: <20140602.102221.1420138426517504976.okuno.kohji@jp.panasonic.com>
In-Reply-To: <20140602.102221.1420138426517504976.okuno.kohji@jp.panasonic.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
 <freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current/>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
 <mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 02 Jun 2014 07:09:44 -0000

On 06/02/14 03:22, Kohji Okuno wrote:
> Hi HPS,
>
> I think the type of physaddr in struct usb_page is incorrect.
> We shuld use bus_addr_t for physaddr.
> What do you think about this?
>
> 60	 * The following structure defines physical and non kernel virtual
> 61	 * address of a memory page having size USB_PAGE_SIZE.
> 62	 */
> 63	struct usb_page {
> 64	#if USB_HAVE_BUSDMA
> 65	        bus_size_t physaddr;
> 66	        void   *buffer;                 /* non Kernel Virtual Address */
> 67	#endif
> 68	};
>
> Regards,
>   Kohji Okuno

Hi,

http://svnweb.freebsd.org/changeset/base/266969

--HPS