From owner-freebsd-bugs@FreeBSD.ORG  Fri Apr 27 12:30:11 2012
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id D970D1065670
	for <freebsd-bugs@hub.freebsd.org>;
	Fri, 27 Apr 2012 12:30:11 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 982B48FC14
	for <freebsd-bugs@hub.freebsd.org>;
	Fri, 27 Apr 2012 12:30:11 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q3RCUBBJ013463
	for <freebsd-bugs@freefall.freebsd.org>; Fri, 27 Apr 2012 12:30:11 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q3RCUBAV013459;
	Fri, 27 Apr 2012 12:30:11 GMT (envelope-from gnats)
Resent-Date: Fri, 27 Apr 2012 12:30:11 GMT
Resent-Message-Id: <201204271230.q3RCUBAV013459@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org,
	Slawa Olhovchenkov <slw@zxy.spb.ru>
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 32F0E106564A
	for <freebsd-gnats-submit@FreeBSD.org>;
	Fri, 27 Apr 2012 12:27:53 +0000 (UTC)
	(envelope-from nobody@FreeBSD.org)
Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22])
	by mx1.freebsd.org (Postfix) with ESMTP id 1E4D58FC08
	for <freebsd-gnats-submit@FreeBSD.org>;
	Fri, 27 Apr 2012 12:27:53 +0000 (UTC)
Received: from red.freebsd.org (localhost [127.0.0.1])
	by red.freebsd.org (8.14.4/8.14.4) with ESMTP id q3RCRqV7053017
	for <freebsd-gnats-submit@FreeBSD.org>; Fri, 27 Apr 2012 12:27:52 GMT
	(envelope-from nobody@red.freebsd.org)
Received: (from nobody@localhost)
	by red.freebsd.org (8.14.4/8.14.4/Submit) id q3RCRq3K053016;
	Fri, 27 Apr 2012 12:27:52 GMT (envelope-from nobody)
Message-Id: <201204271227.q3RCRq3K053016@red.freebsd.org>
Date: Fri, 27 Apr 2012 12:27:52 GMT
From: Slawa Olhovchenkov <slw@zxy.spb.ru>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-3.1
Cc: 
Subject: bin/167361: pmcstat crashed if symbols found (striped image)
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 27 Apr 2012 12:30:11 -0000


>Number:         167361
>Category:       bin
>Synopsis:       pmcstat crashed if symbols found (striped image)
>Confidential:   no
>Severity:       non-critical
>Priority:       high
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Fri Apr 27 12:30:11 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator:     Slawa Olhovchenkov
>Release:        10-CURRENT
>Organization:
>Environment:
FreeBSD  10.0-CURRENT FreeBSD 10.0-CURRENT #18: Tue Apr 24 16:42:14 MSK 2012     root@:/usr/obj/usr/src/sys/NETMAP  amd64

>Description:
pmcstat try to load symbols from striped files and crashed at pmcstat_log.c:592 (symptr is NULL).

>How-To-Repeat:
Run pmcstat on system with striped world.

>Fix:
patch pmcstat_log.c

Patch attached with submission follows:

--- pmcstat_log.c.orig	2012-04-27 15:50:05.000000000 +0400
+++ pmcstat_log.c	2012-04-27 15:50:56.000000000 +0400
@@ -565,6 +565,8 @@
 	image->pi_symcount += newsyms;
 
 	assert(newsyms <= nfuncsyms);
+	if(image->pi_symcount == 0)
+	    return;
 
 	/*
 	 * Return space to the system if there were duplicates.


>Release-Note:
>Audit-Trail:
>Unformatted: