From owner-freebsd-ports@FreeBSD.ORG Sat Mar 27 17:40:07 2004 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6883816A4CE; Sat, 27 Mar 2004 17:40:07 -0800 (PST) Received: from meitner.wh.uni-dortmund.de (meitner.wh.uni-dortmund.de [129.217.129.133]) by mx1.FreeBSD.org (Postfix) with ESMTP id EFFA643D2D; Sat, 27 Mar 2004 17:40:06 -0800 (PST) (envelope-from michaelnottebrock@gmx.net) Received: from lofi.dyndns.org (pc2-105.intern.meitner [10.3.12.105]) by meitner.wh.uni-dortmund.de (Postfix) with ESMTP id 1401716758E; Sun, 28 Mar 2004 03:40:06 +0200 (CEST) Received: from [192.168.8.4] (kiste.my.domain [192.168.8.4]) (authenticated bits=0) by lofi.dyndns.org (8.12.10/8.12.10) with ESMTP id i2S1e2fm093879 (version=TLSv1/SSLv3 cipher=RC4-MD5 bits=128 verify=NO); Sun, 28 Mar 2004 03:40:02 +0200 (CEST) (envelope-from michaelnottebrock@gmx.net) From: Michael Nottebrock To: freebsd-ports@freebsd.org, pav@freebsd.org Date: Sun, 28 Mar 2004 02:39:58 +0100 User-Agent: KMail/1.6.1 References: <20040327200136.31711.qmail@laurel.tmseck.homedns.org> <1080436501.75008.5.camel@hood.oook.cz> In-Reply-To: <1080436501.75008.5.camel@hood.oook.cz> MIME-Version: 1.0 Content-Type: multipart/signed; protocol="application/pgp-signature"; micalg=pgp-sha1; boundary="Boundary-02=_xziZACIy6KTckBa"; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Message-Id: <200403280340.01956.michaelnottebrock@gmx.net> X-Virus-Scanned: by amavisd-new cc: SADA Kenji cc: Thomas-Martin Seck Subject: Re: treating OPTIONS X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 28 Mar 2004 01:40:07 -0000 --Boundary-02=_xziZACIy6KTckBa Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Sunday 28 March 2004 03:15, Pav Lucistnik wrote: > V so, 27. 03. 2004 v 21:01, Thomas-Martin Seck p=ED=A8e: > > * SADA Kenji [gmane.os.freebsd.devel.ports]: > > > .if exists(${LOCALBASE}/lib/libldap.so) > > > WITH_LDAP=3D yes > > > OPTIONS+=3D LDAP "Support for LDAP queries" on > > > .else > > > OPTIONS+=3D LDAP "Support for LDAP queries" off > > > .endif > > > > Please do not do this. IMHO, ports that autotune themselves are a bad > > idea and abusing OPTIONS for this is even worse. If you - as the > > maintainer - decide that LDAP support is optional, default the port to > > not include it. Period. If the user wants LDAP she can always say so > > herself, either via the commandline or via 'make config'. > > Why not? This is a common practice that port autodetects optional > dependencies and automatically enable/disable them. Something I only realised yesterday (hi kris) is that OPTIONS do not just s= et=20 WITH_FOO but also WITHOUT_FOO, so for autodetecting things you'd have to=20 check .if exists(bar) and !defined WITHOUT_FOO then define WITH_FOO... I'm= =20 currently changing the KDE ports do do away with autodetection where possib= le=20 and just enforce config instead. It makes building of customized packagas=20 easier as a side effect. =2D-=20 ,_, | Michael Nottebrock | lofi@freebsd.org (/^ ^\) | FreeBSD - The Power to Serve | http://www.freebsd.org \u/ | K Desktop Environment on FreeBSD | http://freebsd.kde.org --Boundary-02=_xziZACIy6KTckBa Content-Type: application/pgp-signature Content-Description: signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (FreeBSD) iD8DBQBAZizxXhc68WspdLARAr+6AJ0Rm7EkBVEILtca99NGhX1ivOEyWgCfUjZH bgOjxjJVQX7VYmx/DeP0IVI= =LXmj -----END PGP SIGNATURE----- --Boundary-02=_xziZACIy6KTckBa--