Date: Tue, 13 Jul 2004 09:50:15 -0700 (PDT) From: Alex Varju <varju@webct.com> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/69007: Fix palm/jpilot build on 4.10 with GTK2 enabled Message-ID: <200407131650.i6DGoFk2056391@snapple.webct.com> Resent-Message-ID: <200407131700.i6DH0dZ3019797@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 69007 >Category: ports >Synopsis: Fix palm/jpilot build on 4.10 with GTK2 enabled >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: maintainer-update >Submitter-Id: current-users >Arrival-Date: Tue Jul 13 17:00:38 GMT 2004 >Closed-Date: >Last-Modified: >Originator: Alex Varju >Release: FreeBSD 5.2-RELEASE i386 >Organization: WebCT >Environment: System: FreeBSD snapple.webct.com 5.2-RELEASE FreeBSD 5.2-RELEASE #10: Fri Jan 16 17:24:29 PST 2004 varju@snapple.webct.com:/usr/obj/usr/src/sys/SNAPPLE i386 >Description: There is a bug in jpilot 0.99.7 which prevents builds from succeeding on 4.10 when USE_GTK2 is enabled. The attached patch fixes the code so that it can compile with older versions of GCC. I have not bumped the PORTREVISION because this bug prevent builds on 4.10, and the patch doesn't change anything significant for 5.x. This fix was pointed out by Alexander Koch <mail@kochalexander.de> >How-To-Repeat: >Fix: --- /dev/null Tue Jul 13 09:44:33 2004 +++ ports/palm/jpilot/files/patch-address_gui.c Mon Jul 12 18:14:34 2004 @@ -0,0 +1,20 @@ +--- address_gui.c~ 2004-05-11 22:33:45.364123000 -0400 ++++ address_gui.c 2004-05-11 22:38:37.506140000 -0400 +@@ -1427,13 +1427,15 @@ + char number[100]; + char ext[100]; + +- number[0]=ext[0]='\0'; +- text=data; + #ifdef ENABLE_GTK2 + GtkTextIter start_iter; + GtkTextIter end_iter; + GtkTextBuffer *text_buffer; ++#endif + ++ number[0]=ext[0]='\0'; ++ text=data; ++#ifdef ENABLE_GTK2 + text_buffer = gtk_text_view_get_buffer(GTK_TEXT_VIEW(text)); + gtk_text_buffer_get_bounds(GTK_TEXT_BUFFER(text),&start_iter,&end_iter); + str = gtk_text_buffer_get_text(GTK_TEXT_BUFFER(text),&start_iter,&end_iter,TRUE); >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200407131650.i6DGoFk2056391>