From owner-freebsd-ports-bugs@FreeBSD.ORG Tue Jul 13 17:00:40 2004 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B2A4A16A4CF for ; Tue, 13 Jul 2004 17:00:40 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 879B343D5A for ; Tue, 13 Jul 2004 17:00:40 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) i6DH0doQ019801 for ; Tue, 13 Jul 2004 17:00:39 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i6DH0dZ3019797; Tue, 13 Jul 2004 17:00:39 GMT (envelope-from gnats) Resent-Date: Tue, 13 Jul 2004 17:00:39 GMT Resent-Message-Id: <200407131700.i6DH0dZ3019797@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Alex Varju Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B6A5716A4CE for ; Tue, 13 Jul 2004 16:50:16 +0000 (GMT) Received: from snapple.webct.com (snapple.webct.com [209.87.17.45]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3CF0C43D4C for ; Tue, 13 Jul 2004 16:50:16 +0000 (GMT) (envelope-from varju@snapple.webct.com) Received: from snapple.webct.com (localhost [127.0.0.1]) by snapple.webct.com (8.12.10/8.12.10) with ESMTP id i6DGoG6n056392 for ; Tue, 13 Jul 2004 09:50:16 -0700 (PDT) (envelope-from varju@snapple.webct.com) Received: (from root@localhost) by snapple.webct.com (8.12.10/8.12.10/Submit) id i6DGoFk2056391; Tue, 13 Jul 2004 09:50:15 -0700 (PDT) (envelope-from varju) Message-Id: <200407131650.i6DGoFk2056391@snapple.webct.com> Date: Tue, 13 Jul 2004 09:50:15 -0700 (PDT) From: Alex Varju To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: ports/69007: Fix palm/jpilot build on 4.10 with GTK2 enabled X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Alex Varju List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Jul 2004 17:00:40 -0000 >Number: 69007 >Category: ports >Synopsis: Fix palm/jpilot build on 4.10 with GTK2 enabled >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: maintainer-update >Submitter-Id: current-users >Arrival-Date: Tue Jul 13 17:00:38 GMT 2004 >Closed-Date: >Last-Modified: >Originator: Alex Varju >Release: FreeBSD 5.2-RELEASE i386 >Organization: WebCT >Environment: System: FreeBSD snapple.webct.com 5.2-RELEASE FreeBSD 5.2-RELEASE #10: Fri Jan 16 17:24:29 PST 2004 varju@snapple.webct.com:/usr/obj/usr/src/sys/SNAPPLE i386 >Description: There is a bug in jpilot 0.99.7 which prevents builds from succeeding on 4.10 when USE_GTK2 is enabled. The attached patch fixes the code so that it can compile with older versions of GCC. I have not bumped the PORTREVISION because this bug prevent builds on 4.10, and the patch doesn't change anything significant for 5.x. This fix was pointed out by Alexander Koch >How-To-Repeat: >Fix: --- /dev/null Tue Jul 13 09:44:33 2004 +++ ports/palm/jpilot/files/patch-address_gui.c Mon Jul 12 18:14:34 2004 @@ -0,0 +1,20 @@ +--- address_gui.c~ 2004-05-11 22:33:45.364123000 -0400 ++++ address_gui.c 2004-05-11 22:38:37.506140000 -0400 +@@ -1427,13 +1427,15 @@ + char number[100]; + char ext[100]; + +- number[0]=ext[0]='\0'; +- text=data; + #ifdef ENABLE_GTK2 + GtkTextIter start_iter; + GtkTextIter end_iter; + GtkTextBuffer *text_buffer; ++#endif + ++ number[0]=ext[0]='\0'; ++ text=data; ++#ifdef ENABLE_GTK2 + text_buffer = gtk_text_view_get_buffer(GTK_TEXT_VIEW(text)); + gtk_text_buffer_get_bounds(GTK_TEXT_BUFFER(text),&start_iter,&end_iter); + str = gtk_text_buffer_get_text(GTK_TEXT_BUFFER(text),&start_iter,&end_iter,TRUE); >Release-Note: >Audit-Trail: >Unformatted: