From owner-freebsd-usb@FreeBSD.ORG Wed Mar 28 06:17:46 2007 Return-Path: X-Original-To: freebsd-usb@freebsd.org Delivered-To: freebsd-usb@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 2167D16A401 for ; Wed, 28 Mar 2007 06:17:46 +0000 (UTC) (envelope-from alexander@leidinger.net) Received: from redbull.bpaserver.net (redbullneu.bpaserver.net [213.198.78.217]) by mx1.freebsd.org (Postfix) with ESMTP id C88C113C48C for ; Wed, 28 Mar 2007 06:17:45 +0000 (UTC) (envelope-from alexander@leidinger.net) Received: from outgoing.leidinger.net (p54a5f07f.dip.t-dialin.net [84.165.240.127]) by redbull.bpaserver.net (Postfix) with ESMTP id 9A5002E215; Wed, 28 Mar 2007 08:00:03 +0200 (CEST) Received: from webmail.leidinger.net (webmail.Leidinger.net [192.168.1.102]) by outgoing.leidinger.net (Postfix) with ESMTP id CA30B5B4817; Wed, 28 Mar 2007 08:00:00 +0200 (CEST) Received: (from www@localhost) by webmail.leidinger.net (8.13.8/8.13.8/Submit) id l2S600fX022713; Wed, 28 Mar 2007 08:00:00 +0200 (CEST) (envelope-from Alexander@Leidinger.net) Received: from pslux.cec.eu.int (pslux.cec.eu.int [158.169.9.14]) by webmail.leidinger.net (Horde MIME library) with HTTP; Wed, 28 Mar 2007 08:00:00 +0200 Message-ID: <20070328080000.bhakk1rou88ww8ks@webmail.leidinger.net> X-Priority: 3 (Normal) Date: Wed, 28 Mar 2007 08:00:00 +0200 From: Alexander Leidinger To: grem References: <4609D885.8070505@bindone.de> In-Reply-To: <4609D885.8070505@bindone.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; DelSp="Yes"; format="flowed" Content-Disposition: inline Content-Transfer-Encoding: quoted-printable User-Agent: Internet Messaging Program (IMP) H3 (4.1.3) / FreeBSD-7.0 X-BPAnet-MailScanner-Information: Please contact the ISP for more information X-BPAnet-MailScanner: Found to be clean X-BPAnet-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-14.864, required 8, autolearn=not spam, BAYES_00 -15.00, DK_POLICY_SIGNSOME 0.00, FORGED_RCVD_HELO 0.14) X-BPAnet-MailScanner-From: alexander@leidinger.net X-Spam-Status: No Cc: freebsd-usb@freebsd.org Subject: Re: Support for new device, important fix and enhancement to umass.c X-BeenThere: freebsd-usb@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: FreeBSD support for USB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Mar 2007 06:17:46 -0000 Quoting grem (from Wed, 28 Mar 2007 04:52:53 +0200): [analysis of the problem] > Any feedback is welcome, since I'm not an expert in how USB works/is =20 > implemented in FreeBSD. Please submit this as a problem report. Quirks have to be registered =20 in GNATS before we can commit them so that we are able to reevaluate =20 them if the need arises. > @@ -1665,6 +1673,8 @@ > USETDW(sc->csw.dCSWSignature, CSWSIGNATURE= ); > } > > + if (sc->quirks & IGNORE_RESIDUE) > + USETDW(sc->csw.dCSWDataResidue, 0); > int Residue; > Residue =3D UGETDW(sc->csw.dCSWDataResidue); > if (Residue =3D=3D 0 && Wrong indent for the USETDW line. I don't know much about the USB =20 code. If the residue is not used somewhere else, wouldn't it be better =20 to do "if quirk set the Residue variable to 0 else get it from the =20 device" instead of setting it? Bye, Alexander. --=20 BOFH excuse #71: The file system is full of it http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID =3D B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID =3D 72077137