From owner-cvs-all@FreeBSD.ORG Thu Apr 24 01:26:16 2008 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 49BC01065673; Thu, 24 Apr 2008 01:26:16 +0000 (UTC) (envelope-from xcllnt@mac.com) Received: from smtpoutm.mac.com (smtpoutm.mac.com [17.148.16.72]) by mx1.freebsd.org (Postfix) with ESMTP id 3AB558FC16; Thu, 24 Apr 2008 01:26:15 +0000 (UTC) (envelope-from xcllnt@mac.com) Received: from asmtp011.mac.com (asmtp011-bge351000 [10.150.69.74]) by smtpoutm.mac.com (Xserve/smtpout009/MantshX 4.0) with ESMTP id m3O1QFeN014493; Wed, 23 Apr 2008 18:26:15 -0700 (PDT) MIME-version: 1.0 Content-transfer-encoding: 7BIT Content-type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Received: from [192.168.1.100] (209-128-86-226.bayarea.net [209.128.86.226]) by asmtp011.mac.com (Sun Java(tm) System Messaging Server 6.3-6.03 (built Mar 14 2008; 32bit)) with ESMTPSA id <0JZT008V02NQOK70@asmtp011.mac.com>; Wed, 23 Apr 2008 18:26:15 -0700 (PDT) Message-id: <8764A4AA-DE86-43A6-B161-3159DE7E5AB8@mac.com> From: Marcel Moolenaar To: Peter Wemm In-reply-to: Date: Wed, 23 Apr 2008 18:26:14 -0700 References: <200804190725.m3J7Pvie056329@repoman.freebsd.org> <200804230858.31200.jhb@freebsd.org> X-Mailer: Apple Mail (2.919.2) Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org, John Baldwin Subject: Re: cvs commit: src/sys/amd64/amd64 machdep.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Apr 2008 01:26:16 -0000 On Apr 23, 2008, at 5:40 PM, Peter Wemm wrote: > On Wed, Apr 23, 2008 at 5:58 AM, John Baldwin wrote: >> On Saturday 19 April 2008 03:25:57 am Peter Wemm wrote: >>> peter 2008-04-19 07:25:57 UTC >>> >>> FreeBSD src repository >>> >>> Modified files: >>> sys/amd64/amd64 machdep.c >>> Log: >>> Put in a real isa_irq_pending() stub in order to remove two lines >>> of >>> dmesg noise from sio per unit. sio likes to probe if interrupts are >>> configured correctly by looking at the pending bits of the atpic >>> in order >>> to put a non-fatal warning on the console. I think I'd rather >>> read the >>> pending bits from the apics, but I'm not sure its worth the hassle. >> >> Actually, the x86 interrupt sources have a pending method so this >> can be >> replaced. Could probably easily write something like this: >> >> int >> intr_pending(u_int irq) >> { >> struct intsrc *isrc; >> >> isc = intr_lookup_source(irq); >> if (isrc == NULL) >> panic("bizarre"); >> return (isrc->is_pic->pic_pending(isrc)); >> } >> >> For intr_machdep.c and use this in sio: >> >> #if defined(__i386__) || defined(__amd64__) >> foo = intr_pending(rman_get_start(irq_resource)); >> #else >> foo = isa_irq_pending() & (1 << rman_get_start(irq_resource)); >> #endif >> >> or some such. I'd really prefer to kill isa_irq_pending(). > > Let's just add intr_pending() to all MD backends that currently > provide isa_irq_pending() for sio's benenfit. Either as a simple > wrapper around the now-static local isa_irq_pending() (ia64), or by > simplifying and converting isa_irq_pending() into intr_pending() > (sparc64). sio() is only for i386 and amd64, isa_irq_pending() should be removed from all MD code, except from i386 and amd64. FYI, -- Marcel Moolenaar xcllnt@mac.com