From owner-svn-src-head@freebsd.org Thu Oct 20 19:56:20 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 82C10C1A4C7; Thu, 20 Oct 2016 19:56:20 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: from mail-lf0-x22c.google.com (mail-lf0-x22c.google.com [IPv6:2a00:1450:4010:c07::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 2B2706BE; Thu, 20 Oct 2016 19:56:20 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: by mail-lf0-x22c.google.com with SMTP id b75so99252392lfg.3; Thu, 20 Oct 2016 12:56:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=rLfXp7+1AR2yXPyD7bpk5H/sp/IfJC/VKBy1K+VNmBM=; b=qMI2c/rTPBd6AQL6nIyZDFJjEIUrHyXpr35BohhuXYOczWEvmu/Ti8LAqVtti7CDh6 ovsvqwp1fcWxZ4LQfI1fA8HKp1TR0edafcs+chmVVIZVOiCdfsmvwKjaPVX8c/EXRBXn oYGUodrx2hFqLUFsxaRm1sfvvGv1BMcoLiq6QUPgmbmK4ueeGiqTVit34iIlyfRisLZO bD8WKuiTSeHo/sCqL8Ik+hTa86q1myvlOYS9CXKjPjCzfkSXgVQrzcjplnBvM0i9xa+M JfW5wH7uSlqIACm8wN6DLSCLNW86T/LBIl784iVMcjl/WZP448u0iHY6uQOoKW9Zg4fV XsBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=rLfXp7+1AR2yXPyD7bpk5H/sp/IfJC/VKBy1K+VNmBM=; b=k1Kh/tv9ctC9kT/TRR0yc5L7BRfvojRhU6RwtHYuRwLbdBh87CZmvcovDFG+T0axg2 hSVrdYwKFPR7f/Q4wQD8JYo/r1dFofaG9GVj3SVc4X/HliD9JxuBTR1lZ4zTjhsSG7t+ bBZYzYLdUBR3iuG4kvIe0sRzll8rCLDu9jPdZhpsVUZMQgOq7BRD3sWZjUzd4oDmJzWI RnQBZYL/Mlsocl1yAggedgwHgzZkWShOhhnoWPaL6bNQHNZuKiQQzT/wAbDp6EIBUYax O+g50ZvdZoUBIoBiLW0t2iDJhPoCZ9mC3tfUb/gs8NiAJW2fK2Akb0cQDXJt5XwxL8LE 4LKw== X-Gm-Message-State: AA6/9RnljGRJeqAj+fWqjfjkwxL2RonrZydkn5ofommNrBsZD6vv6f6TjherZh1b+Pa9gw== X-Received: by 10.28.232.148 with SMTP id f20mr37322wmi.30.1476993377707; Thu, 20 Oct 2016 12:56:17 -0700 (PDT) Received: from dft-labs.eu (n1x0n-1-pt.tunnel.tserv5.lon1.ipv6.he.net. [2001:470:1f08:1f7::2]) by smtp.gmail.com with ESMTPSA id p3sm81173900wjr.31.2016.10.20.12.56.16 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Thu, 20 Oct 2016 12:56:17 -0700 (PDT) Date: Thu, 20 Oct 2016 21:56:15 +0200 From: Mateusz Guzik To: Gleb Smirnoff Cc: Mateusz Guzik , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r307650 - head/sys/kern Message-ID: <20161020195614.GA31016@dft-labs.eu> References: <201610191829.u9JITqhm081246@repo.freebsd.org> <20161019220942.GM27748@FreeBSD.org> <20161020115035.GA26990@dft-labs.eu> <20161020181827.GU27748@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20161020181827.GU27748@FreeBSD.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Oct 2016 19:56:20 -0000 On Thu, Oct 20, 2016 at 11:18:27AM -0700, Gleb Smirnoff wrote: > On Thu, Oct 20, 2016 at 01:50:35PM +0200, Mateusz Guzik wrote: > M> On Wed, Oct 19, 2016 at 03:09:42PM -0700, Gleb Smirnoff wrote: > M> > On Wed, Oct 19, 2016 at 06:29:52PM +0000, Mateusz Guzik wrote: > M> > M> Author: mjg > M> > M> Date: Wed Oct 19 18:29:52 2016 > M> > M> New Revision: 307650 > M> > M> URL: https://svnweb.freebsd.org/changeset/base/307650 > M> > M> > M> > M> Log: > M> > M> cache: split negative entry LRU into multiple lists > M> > M> > M> > M> This splits the ncneg_mtx lock while preserving the hit ratio at least > M> > M> during buildworld. > M> > M> > M> > M> Create N dedicated lists for new negative entries. > M> > M> > M> > M> Entries with at least one hit get promoted to the hot list, where they > M> > M> get requeued every M hits. > M> > M> > M> > M> Shrinking demotes one hot entry and performs a round-robin shrinking of > M> > M> regular lists. > M> > M> > M> > M> Reviewed by: kib > M> > > M> > This instapanics: > M> > > M> > panic: Assertion ncp->nc_flag & NCF_NEGATIVE failed at /usr/src/head/sys/kern/vfs_cache.c:815 > M> > > M> > M> It definitely works for me and I don't see how the condition can fail. > M> > M> Given the 'instapanic' note, I assume you can easily reproduce. Is this > M> a stock head kernel? > M> > M> Can you reproduce with; > > Trying to mount root from ufs:/dev/vtbd0p3 [rw]... > panic: cache_negative_zap_one: ncp 0xffffffff81012500 flag 0 dvp 0 vp 0 > Fixed in r307685. -- Mateusz Guzik