From owner-dev-commits-src-branches@freebsd.org Mon Apr 26 16:57:53 2021 Return-Path: Delivered-To: dev-commits-src-branches@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 2D9F45E8BA7 for ; Mon, 26 Apr 2021 16:57:53 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qv1-xf32.google.com (mail-qv1-xf32.google.com [IPv6:2607:f8b0:4864:20::f32]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FTWKs0Gx4z3s2p for ; Mon, 26 Apr 2021 16:57:52 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qv1-xf32.google.com with SMTP id x14so4238242qvr.5 for ; Mon, 26 Apr 2021 09:57:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XuNcwb0h/A2WhgK7MzHTqZcy+V9PDnnUk3EsPLDZSfY=; b=dH4vN9rwzz1u78wmQUa0qIAh4aEOW1ARBiKw8YMWR1foB7QKrnW6Ib7roONeE9v1Ox 908Vlq9KLiJtQ8K8ZswhLxhMYrbJK6mgoTAt/r4wV0VMZXlbyjZAIoaFeMt2Jq3/QM1u FU1nPGMyZyHd1I9XvVQKVH6sGuWVDYI2viaAF3hEpj5mZ75pFHRyiCsOIHJNRMARAwPo NkiX76S+nRfB6AMFKSUNmMhqylpZYDSKKuW/6Isii4DzPoWSwjHCtSVFn+v9QJqpQxby /p7CGTXNqWjEOiLOLiEz+ir557mcqD81jDYyoUVtdd9C2vs0b85+xHPWCOEQPHuqjaZj iSDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XuNcwb0h/A2WhgK7MzHTqZcy+V9PDnnUk3EsPLDZSfY=; b=m4yDhoa/+bAfL4BEU6ufN/vNpGVXF+aBeXcO+4r9NvSLk1fnv6NBPwr3jTHlhnvCdO HXUbXYiErFaNKJgcEZpQcCFSd+B/F5elxw/GobH69iUHMsViRlURovdvBLY5n3jsP1Ik 0Xf4V7Weydlfm+z9+Wmw1snclEM0njFVtUlMcyEYxQyzWBdIkV+CBDIfDfWeWOuqNjnL ppGqfBGbIcyyElbuuncMBFML5vHB+UAhTDpk8Lu9rl9nfzHwOTASjlh5L+qQAOVW9h5m 3PDLYlOJguqeKnv46Xgwh+KC1uVyCgMpJPAO8Ox5Pu1uRnPOEfxtS56IKz+Goh8BqyJX QEkA== X-Gm-Message-State: AOAM530W2WeRXY9jgDNSxSIeSJcuVVDWRErCF9nI/Zh0lVa8f4rYQ9wB O/4VEvBSuDKI7b5E8aC6loCh7eYyuqVS25eTBG8WjA== X-Google-Smtp-Source: ABdhPJyOhgQUTwfnSE5vdpCkQiQbXxwhfeFn7MXS8IYtI5tqG1lz1OqVusrSCU9BsnxNApBVs31asiCSsm1mBaxTXh8= X-Received: by 2002:a0c:9ad7:: with SMTP id k23mr18879256qvf.24.1619456271963; Mon, 26 Apr 2021 09:57:51 -0700 (PDT) MIME-Version: 1.0 References: <202104261545.13QFjAYB012989@gitrepo.freebsd.org> <20210426160242.7nddbshrccusdb5j@mutt-hbsd> <67e6aa7a-3c1d-1055-d468-b6a366382f04@FreeBSD.org> In-Reply-To: From: Warner Losh Date: Mon, 26 Apr 2021 10:57:40 -0600 Message-ID: Subject: Re: git: 9db8b85a942d - stable/13 - linuxkpi: Remove unneeded {} in atomic_dec_and_lock_irqsave() To: Neel Chauhan Cc: John Baldwin , Shawn Webb , src-committers , "" , dev-commits-src-branches@freebsd.org X-Rspamd-Queue-Id: 4FTWKs0Gx4z3s2p X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.34 X-BeenThere: dev-commits-src-branches@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commits to the stable branches of the FreeBSD src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Apr 2021 16:57:53 -0000 On Mon, Apr 26, 2021 at 10:49 AM Neel Chauhan wrote: > On 2021-04-26 09:42, John Baldwin wrote: > > I agree. 20 minutes is far too short. The normal minimum is 3 days. > > You already have feedback on the commits to main that you should > > probably adjust before merging (specifically Mateusz's quite salient > > point). > > Requiring two immediate fixups to the original commit in main is also > > indicative that the change in question isn't really ready yet. > > Sorry about this. I'm new(-ish?) to src. > > The immediate "fixups" are just formatting changes that were requested, > not really bugfixes. > Only extremely urgent security-related or build-breakage-fixes are to be MFC'd faster than 3 days. At least that's been the rule we've articulated in the past. There's been some flexibility for things that are important, or when racing a release / snapshot schedule (eg a really good reason based on external factors) Warner